quic: address review comments

jasnell · jasnell · commit 918abb9de567 · 2023-12-09T10:31:33.000-08:00
diff --git a/src/dataqueue/queue.cc b/src/dataqueue/queue.cc
@@ -176,10 +176,10 @@ class DataQueueImpl final : public DataQueue,
 
   void NotifyBackpressure(size_t amount) {
     if (idempotent_) return;
-    for (auto listener : backpressure_listeners_) listener->EntryRead(amount);
+    for (auto& listener : backpressure_listeners_) listener->EntryRead(amount);
   }
 
-  bool HasBackpressureListeners() const {
+  bool HasBackpressureListeners() const noexcept {
     return !backpressure_listeners_.empty();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -176,10 +176,10 @@ class DataQueueImpl final : public DataQueue,`
`176`	`176`
`177`	`177`	`void NotifyBackpressure(size_t amount) {`
`178`	`178`	`if (idempotent_) return;`
`179`		`- for (auto listener : backpressure_listeners_) listener->EntryRead(amount);`
	`179`	`+ for (auto& listener : backpressure_listeners_) listener->EntryRead(amount);`
`180`	`180`	`}`
`181`	`181`
`182`		`- bool HasBackpressureListeners() const {`
	`182`	`+ bool HasBackpressureListeners() const noexcept {`
`183`	`183`	`return !backpressure_listeners_.empty();`
`184`	`184`	`}`
`185`	`185`