Skip to content

Commit 990c968

Browse files
committed
build: respect --shared-* flags for inspector deps
Don't build openssl/http_parser/libuv for v8_inspector if corresponding --shared-* flags were passed to the ./configure script. Fixes: #7478 Fixes: #7583 PR-URL: #7569 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
1 parent 245ac30 commit 990c968

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

node.gyp

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -826,14 +826,26 @@
826826

827827
'conditions': [
828828
['v8_inspector=="true"', {
829-
'dependencies': [
830-
'deps/openssl/openssl.gyp:openssl',
831-
'deps/http_parser/http_parser.gyp:http_parser',
832-
'deps/uv/uv.gyp:libuv'
833-
],
834829
'sources': [
835830
'src/inspector_socket.cc',
836831
'test/cctest/test_inspector_socket.cc'
832+
],
833+
'conditions': [
834+
[ 'node_shared_openssl=="false"', {
835+
'dependencies': [
836+
'deps/openssl/openssl.gyp:openssl'
837+
]
838+
}],
839+
[ 'node_shared_http_parser=="false"', {
840+
'dependencies': [
841+
'deps/http_parser/http_parser.gyp:http_parser'
842+
]
843+
}],
844+
[ 'node_shared_libuv=="false"', {
845+
'dependencies': [
846+
'deps/uv/uv.gyp:libuv'
847+
]
848+
}]
837849
]
838850
}],
839851
[ 'node_use_v8_platform=="true"', {

0 commit comments

Comments
 (0)