Skip to content

Commit a892d9a

Browse files
dayninBridgeAR
authored andcommitted
url: use existing handlers instead of duplicated code
PR-URL: #19267 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent b34a1e1 commit a892d9a

File tree

1 file changed

+7
-14
lines changed

1 file changed

+7
-14
lines changed

lib/internal/url.js

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -256,20 +256,6 @@ function onParseProtocolComplete(flags, protocol, username, password,
256256
ctx.port = port;
257257
}
258258

259-
function onParseHostComplete(flags, protocol, username, password,
260-
host, port, path, query, fragment) {
261-
const ctx = this[context];
262-
if ((flags & URL_FLAGS_HAS_HOST) !== 0) {
263-
ctx.host = host;
264-
ctx.flags |= URL_FLAGS_HAS_HOST;
265-
} else {
266-
ctx.host = null;
267-
ctx.flags &= ~URL_FLAGS_HAS_HOST;
268-
}
269-
if (port !== null)
270-
ctx.port = port;
271-
}
272-
273259
function onParseHostnameComplete(flags, protocol, username, password,
274260
host, port, path, query, fragment) {
275261
const ctx = this[context];
@@ -287,6 +273,13 @@ function onParsePortComplete(flags, protocol, username, password,
287273
this[context].port = port;
288274
}
289275

276+
function onParseHostComplete(flags, protocol, username, password,
277+
host, port, path, query, fragment) {
278+
onParseHostnameComplete.apply(this, arguments);
279+
if (port !== null)
280+
onParsePortComplete.apply(this, arguments);
281+
}
282+
290283
function onParsePathComplete(flags, protocol, username, password,
291284
host, port, path, query, fragment) {
292285
const ctx = this[context];

0 commit comments

Comments
 (0)