fixup! module: handle cached linked async jobs in require(esm)

Author: joyeecheung

lib/internal/modules/esm/loader.js

@@ -97,6 +97,23 @@ function getTranslators() {
   return translators;
 }
 
+/**
+ * Generate message about potential race condition caused by requiring a cached module that has started
+ * async linking.
+ * @param {string} filename Filename of the module being required.
+ * @param {string|undefined} parentFilename Filename of the module calling require().
+ * @returns {string} Error message.
+ */
+function getRaceMessage(filename, parentFilename) {
+  let raceMessage = `Cannot require() ES Module ${filename} because it is not yet fully loaded. `;
+  raceMessage += 'This may be caused by a race condition if the module is simultaneously dynamically ';
+  raceMessage += 'import()-ed via Promise.all(). Try await-ing the import() sequentially in a loop instead.';
+  if (parentFilename) {
+    raceMessage += ` (from ${parentFilename})`;
+  }
+  return raceMessage;
+}
+
 /**
  * @type {HooksProxy}
  * Multiple loader instances exist for various, specific reasons (see code comments at site).
@@ -362,14 +379,8 @@ class ModuleLoader {
       mod[kRequiredModuleSymbol] = job.module;
       const parentFilename = urlToFilename(parent?.filename);
       // TODO(node:55782): this race may stop to happen when the ESM resolution and loading become synchronous.
-      let raceMessage = `Cannot require() ES Module ${filename} because it is not yet fully loaded. `;
-      raceMessage += 'This may be caused by a race condition if the module is simultaneously dynamically ';
-      raceMessage += 'import()-ed via Promise.all(). Try await-ing the import() sequentially in a loop instead.';
-      if (parentFilename) {
-        raceMessage += ` (from ${parentFilename})`;
-      }
       if (!job.module) {
-        assert(job.module, raceMessage);
+        assert.fail(getRaceMessage(filename, parentFilename));
       }
       if (job.module.async) {
         throw new ERR_REQUIRE_ASYNC_MODULE(filename, parentFilename);
@@ -398,7 +409,8 @@ class ModuleLoader {
         throwIfPromiseRejected(job.instantiated);
       }
       if (status !== kEvaluating) {
-        assert.fail(`Unexpected module status ${status}. ` + raceMessage);
+        assert.fail(`Unexpected module status ${status}. ` +
+                    getRaceMessage(filename, parentFilename));
       }
       let message = `Cannot require() ES Module ${filename} in a cycle.`;
       if (parentFilename) {