src: remove unnecessary ToLocalChecked call

danbev · codebytere · commit c2f49319b7df · 2020-06-18T10:19:53.000-07:00
PR-URL: #33683 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/src/node_native_module_env.cc b/src/node_native_module_env.cc
@@ -131,8 +131,9 @@ void NativeModuleEnv::CompileFunction(const FunctionCallbackInfo<Value>& args) {
       NativeModuleLoader::GetInstance()->CompileAsModule(
           env->context(), id, &result);
   RecordResult(id, result, env);
-  if (!maybe.IsEmpty()) {
-    args.GetReturnValue().Set(maybe.ToLocalChecked());
+  Local<Function> fn;
+  if (maybe.ToLocal(&fn)) {
+    args.GetReturnValue().Set(fn);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -131,8 +131,9 @@ void NativeModuleEnv::CompileFunction(const FunctionCallbackInfo<Value>& args) {`
`131`	`131`	`NativeModuleLoader::GetInstance()->CompileAsModule(`
`132`	`132`	`env->context(), id, &result);`
`133`	`133`	`RecordResult(id, result, env);`
`134`		`- if (!maybe.IsEmpty()) {`
`135`		`- args.GetReturnValue().Set(maybe.ToLocalChecked());`
	`134`	`+ Local<Function> fn;`
	`135`	`+ if (maybe.ToLocal(&fn)) {`
	`136`	`+ args.GetReturnValue().Set(fn);`
`136`	`137`	`}`
`137`	`138`	`}`
`138`	`139`