Skip to content

Commit d68ee7e

Browse files
committed
deps: cherry-pick 04a06c9 from upstream V8
Original commit message: [inspector] Make test byte order independent Change-Id: If0fdc76170ad29b4d3dadddbb32bc87c307c04af Reviewed-on: https://chromium-review.googlesource.com/881883 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#50817} Refs: v8/v8@04a06c9 PR-URL: #18453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 3b1e5d9 commit d68ee7e

File tree

3 files changed

+23
-23
lines changed

3 files changed

+23
-23
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
# Reset this number to 0 on major V8 upgrades.
2929
# Increment by one for each non-official patch applied to deps/v8.
30-
'v8_embedder_string': '-node.0',
30+
'v8_embedder_string': '-node.1',
3131

3232
# Enable disassembler for `--print-code` v8 options
3333
'v8_enable_disassembler': 1,

deps/v8/test/inspector/runtime/get-properties-expected.txt

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -54,33 +54,33 @@ Running test: testTypedArrayWithoutLength
5454
Running test: testArrayBuffer
5555
[[Int8Array]]
5656
0 own number 1
57-
1 own number 2
58-
2 own number 3
59-
3 own number 4
60-
4 own number 5
61-
5 own number 6
62-
6 own number 7
63-
7 own number 8
57+
1 own number 1
58+
2 own number 1
59+
3 own number 1
60+
4 own number 1
61+
5 own number 1
62+
6 own number 1
63+
7 own number 1
6464
__proto__ own object undefined
6565
[[Uint8Array]]
6666
0 own number 1
67-
1 own number 2
68-
2 own number 3
69-
3 own number 4
70-
4 own number 5
71-
5 own number 6
72-
6 own number 7
73-
7 own number 8
67+
1 own number 1
68+
2 own number 1
69+
3 own number 1
70+
4 own number 1
71+
5 own number 1
72+
6 own number 1
73+
7 own number 1
7474
__proto__ own object undefined
7575
[[Int16Array]]
76-
0 own number 513
77-
1 own number 1027
78-
2 own number 1541
79-
3 own number 2055
76+
0 own number 257
77+
1 own number 257
78+
2 own number 257
79+
3 own number 257
8080
__proto__ own object undefined
8181
[[Int32Array]]
82-
0 own number 67305985
83-
1 own number 134678021
82+
0 own number 16843009
83+
1 own number 16843009
8484
__proto__ own object undefined
8585

8686
Running test: testArrayBufferWithBrokenUintCtor

deps/v8/test/inspector/runtime/get-properties.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ InspectorTest.runAsyncTestSuite([
3434
},
3535

3636
async function testArrayBuffer() {
37-
let objectId = await evaluateToObjectId('new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]).buffer');
37+
let objectId = await evaluateToObjectId('new Uint8Array([1, 1, 1, 1, 1, 1, 1, 1]).buffer');
3838
let props = await Protocol.Runtime.getProperties({ objectId, ownProperties: true });
3939
for (let prop of props.result.result) {
4040
if (prop.name === '__proto__')
@@ -49,7 +49,7 @@ InspectorTest.runAsyncTestSuite([
4949
this.uint8array_old = this.Uint8Array;
5050
this.Uint8Array = 42;
5151
})()`);
52-
await logExpressionProperties('new Int8Array([1, 2, 3, 4, 5, 6, 7]).buffer');
52+
await logExpressionProperties('new Int8Array([1, 1, 1, 1, 1, 1, 1]).buffer');
5353
await evaluateToObjectId(`(function() {
5454
this.Uint8Array = this.uint8array_old;
5555
delete this.uint8array_old;

0 commit comments

Comments
 (0)