tty: make process.binding('tty_wrap') internal

PR-URL: #22477
Refs: #22160
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

Author: cjihrig

lib/internal/bootstrap/node.js

@@ -353,6 +353,7 @@
         'http_parser',
         'process_wrap',
         'v8',
+        'tty_wrap',
         'stream_wrap',
         'signal_wrap',
         'crypto',

lib/internal/child_process.js

@@ -26,8 +26,8 @@ const { internalBinding } = require('internal/bootstrap/loaders');
 const { Process } = internalBinding('process_wrap');
 const { WriteWrap } = internalBinding('stream_wrap');
 const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap');
-const { TTY } = process.binding('tty_wrap');
 const { TCP } = internalBinding('tcp_wrap');
+const { TTY } = internalBinding('tty_wrap');
 const { UDP } = process.binding('udp_wrap');
 const SocketList = require('internal/socket_list');
 const { owner_symbol } = require('internal/async_hooks').symbols;

lib/internal/dgram.js

@@ -1,9 +1,9 @@
 'use strict';
 const { codes } = require('internal/errors');
+const { internalBinding } = require('internal/bootstrap/loaders');
 const { UDP } = process.binding('udp_wrap');
 const { isInt32 } = require('internal/validators');
-const TTYWrap = process.binding('tty_wrap');
-const { internalBinding } = require('internal/bootstrap/loaders');
+const TTYWrap = internalBinding('tty_wrap');
 const { UV_EINVAL } = internalBinding('uv');
 const { ERR_INVALID_ARG_TYPE, ERR_SOCKET_BAD_TYPE } = codes;
 const kStateSymbol = Symbol('state symbol');

lib/internal/process/stdio.js

@@ -47,7 +47,8 @@ function getMainThreadStdio() {
 
   function getStdin() {
     if (stdin) return stdin;
-    const tty_wrap = process.binding('tty_wrap');
+    const { internalBinding } = require('internal/bootstrap/loaders');
+    const tty_wrap = internalBinding('tty_wrap');
     const fd = 0;
 
     switch (tty_wrap.guessHandleType(fd)) {
@@ -163,7 +164,8 @@ function setupProcessStdio({ getStdout, getStdin, getStderr }) {
 
 function createWritableStdioStream(fd) {
   var stream;
-  const tty_wrap = process.binding('tty_wrap');
+  const { internalBinding } = require('internal/bootstrap/loaders');
+  const tty_wrap = internalBinding('tty_wrap');
 
   // Note stream._type is used for test-module-load-list.js
 

lib/net.js

@@ -42,7 +42,7 @@ const {
 } = internalBinding('uv');
 
 const { Buffer } = require('buffer');
-const TTYWrap = process.binding('tty_wrap');
+const TTYWrap = internalBinding('tty_wrap');
 const { ShutdownWrap } = internalBinding('stream_wrap');
 const {
   TCP,

lib/tty.js

@@ -23,7 +23,8 @@
 
 const { inherits, _extend } = require('util');
 const net = require('net');
-const { TTY, isTTY } = process.binding('tty_wrap');
+const { internalBinding } = require('internal/bootstrap/loaders');
+const { TTY, isTTY } = internalBinding('tty_wrap');
 const errors = require('internal/errors');
 const {
   ERR_INVALID_FD,

src/tty_wrap.cc

@@ -173,4 +173,4 @@ TTYWrap::TTYWrap(Environment* env,
 
 }  // namespace node
 
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(tty_wrap, node::TTYWrap::Initialize)
+NODE_MODULE_CONTEXT_AWARE_INTERNAL(tty_wrap, node::TTYWrap::Initialize)

test/parallel/test-accessor-properties.js

@@ -1,3 +1,4 @@
+// Flags: --expose-internals
 'use strict';
 
 require('../common');
@@ -9,7 +10,8 @@ const assert = require('assert');
 
 // Objects that call StreamBase::AddMethods, when setting up
 // their prototype
-const TTY = process.binding('tty_wrap').TTY;
+const { internalBinding } = require('internal/test/binding');
+const TTY = internalBinding('tty_wrap').TTY;
 const UDP = process.binding('udp_wrap').UDP;
 
 {

test/parallel/test-stream-base-prototype-accessors-enumerability.js

@@ -1,3 +1,4 @@
+// Flags: --expose-internals
 'use strict';
 
 require('../common');
@@ -9,7 +10,8 @@ require('../common');
 const assert = require('assert');
 
 // Or anything that calls StreamBase::AddMethods when setting up its prototype
-const TTY = process.binding('tty_wrap').TTY;
+const { internalBinding } = require('internal/test/binding');
+const TTY = internalBinding('tty_wrap').TTY;
 
 {
   assert.strictEqual(TTY.prototype.propertyIsEnumerable('bytesRead'), false);

test/parallel/test-tty-backwards-api.js

@@ -1,8 +1,10 @@
+// Flags: --expose-internals
 'use strict';
 const common = require('../common');
 
 const noop = () => {};
-const TTY = process.binding('tty_wrap').TTY = function() {};
+const { internalBinding } = require('internal/test/binding');
+const TTY = internalBinding('tty_wrap').TTY = function() {};
 
 TTY.prototype = {
   setBlocking: noop,