Skip to content

Commit e0a8e1b

Browse files
committed
cares_wrap: remove unused function getHostByName()
Hasn't been used in ages. Also remove its (already disabled) test.
1 parent 6cd7fd7 commit e0a8e1b

File tree

2 files changed

+0
-257
lines changed

2 files changed

+0
-257
lines changed

src/cares_wrap.cc

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -748,31 +748,6 @@ static void Query(const FunctionCallbackInfo<Value>& args) {
748748
}
749749

750750

751-
template <class Wrap>
752-
static void QueryWithFamily(const FunctionCallbackInfo<Value>& args) {
753-
HandleScope scope(node_isolate);
754-
755-
assert(!args.IsConstructCall());
756-
assert(args[0]->IsObject());
757-
assert(args[1]->IsString());
758-
assert(args[2]->IsInt32());
759-
assert(args[3]->IsFunction());
760-
761-
Local<Object> req_wrap_obj = args[0].As<Object>();
762-
Local<String> string = args[1].As<String>();
763-
int family = args[2]->Int32Value();
764-
Local<Function> callback = args[3].As<Function>();
765-
766-
Wrap* wrap = new Wrap(req_wrap_obj);
767-
768-
String::Utf8Value name(string);
769-
int err = wrap->Send(*name, family);
770-
if (err) delete wrap;
771-
772-
args.GetReturnValue().Set(err);
773-
}
774-
775-
776751
void AfterGetAddrInfo(uv_getaddrinfo_t* req, int status, struct addrinfo* res) {
777752
HandleScope scope(node_isolate);
778753

@@ -1066,7 +1041,6 @@ static void Initialize(Handle<Object> target) {
10661041
NODE_SET_METHOD(target, "querySrv", Query<QuerySrvWrap>);
10671042
NODE_SET_METHOD(target, "queryNaptr", Query<QueryNaptrWrap>);
10681043
NODE_SET_METHOD(target, "getHostByAddr", Query<GetHostByAddrWrap>);
1069-
NODE_SET_METHOD(target, "getHostByName", QueryWithFamily<GetHostByNameWrap>);
10701044

10711045
NODE_SET_METHOD(target, "getaddrinfo", GetAddrInfo);
10721046
NODE_SET_METHOD(target, "isIP", IsIP);

test/disabled/test-dns.js

Lines changed: 0 additions & 231 deletions
This file was deleted.

0 commit comments

Comments
 (0)