Skip to content

Commit f50e2b4

Browse files
committed
build: add --v8-disable-object-print flag
--v8-enable-object-print flag is set by default true. so, no way of disable this flag. add a --v8-disable-object-print flag instead that defaults to false. Fixes: #45433
1 parent 3770d3a commit f50e2b4

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

configure.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,13 @@
776776
action='store_true',
777777
dest='v8_enable_object_print',
778778
default=True,
779-
help='compile V8 with auxiliar functions for native debuggers')
779+
help='compile V8 with auxiliary functions for native debuggers')
780+
781+
parser.add_argument('--v8-disable-object-print',
782+
action='store_true',
783+
dest='v8_disable_object_print',
784+
default=False,
785+
help='disable the V8 auxiliary functions for native debuggers')
780786

781787
parser.add_argument('--v8-enable-hugepage',
782788
action='store_true',
@@ -1436,7 +1442,7 @@ def configure_v8(o):
14361442
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
14371443
o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1
14381444
o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0
1439-
o['variables']['v8_enable_object_print'] = 1 if options.v8_enable_object_print else 0
1445+
o['variables']['v8_enable_object_print'] = 0 if options.v8_disable_object_print else 1
14401446
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
14411447
o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks.
14421448
o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1
@@ -1459,6 +1465,10 @@ def configure_v8(o):
14591465
o['variables']['v8_enable_hugepage'] = 1 if options.v8_enable_hugepage else 0
14601466
if options.v8_enable_short_builtin_calls or o['variables']['target_arch'] == 'x64':
14611467
o['variables']['v8_enable_short_builtin_calls'] = 1
1468+
if options.v8_enable_object_print and options.v8_disable_object_print:
1469+
raise Exception(
1470+
'Only one of the --v8-enable-object-print or --v8-disable-object-print options '
1471+
'can be specified at a time.')
14621472

14631473
def configure_openssl(o):
14641474
variables = o['variables']

0 commit comments

Comments
 (0)