Skip to content

Commit fc8e821

Browse files
committed
test: remove common.projectDir
common.projectDir is used in one test, so it's not so common. Remove from common module to the one test file that needs it. PR-URL: #17781 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent a4f44ac commit fc8e821

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

test/common/README.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -340,11 +340,6 @@ original state after calling [`common.hijackStdOut()`][].
340340

341341
Path to the 'root' directory. either `/` or `c:\\` (windows)
342342

343-
### projectDir
344-
* [&lt;String>]
345-
346-
Path to the project directory.
347-
348343
### skip(msg)
349344
* `msg` [&lt;String>]
350345

test/common/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ exports.enoughTestCpu = Array.isArray(cpus) &&
6969
(cpus.length > 1 || cpus[0].speed > 999);
7070

7171
exports.rootDir = exports.isWindows ? 'c:\\' : '/';
72-
exports.projectDir = path.resolve(__dirname, '..', '..');
7372

7473
exports.buildType = process.config.target_defaults.default_configuration;
7574

test/doctool/test-make-doc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const assert = require('assert');
1111
const fs = require('fs');
1212
const path = require('path');
1313

14-
const apiPath = path.resolve(common.projectDir, 'out', 'doc', 'api');
14+
const apiPath = path.resolve(__dirname, '..', '..', 'out', 'doc', 'api');
1515
const docs = fs.readdirSync(apiPath);
1616
assert.ok(docs.includes('_toc.html'));
1717

0 commit comments

Comments
 (0)