stream: fix Writable.destroy performance regression

ronag · ronag · commit fe834195bfce · 2023-10-26T15:52:53.000+02:00
diff --git a/lib/internal/streams/writable.js b/lib/internal/streams/writable.js
@@ -1091,7 +1091,7 @@ Writable.prototype.destroy = function(err, cb) {
   const state = this._writableState;
 
   // Invoke pending callbacks.
-  if ((state[kState] & (kBuffered | kOnFinished | kDestroyed)) !== kDestroyed) {
+  if ((state[kState] & (kBuffered | kOnFinished)) !== 0 && (state[kState] & kDestroyed) === 0) {
     process.nextTick(errorBuffer, state);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1091,7 +1091,7 @@ Writable.prototype.destroy = function(err, cb) {`
`1091`	`1091`	`const state = this._writableState;`
`1092`	`1092`
`1093`	`1093`	`// Invoke pending callbacks.`
`1094`		`- if ((state[kState] & (kBuffered \| kOnFinished \| kDestroyed)) !== kDestroyed) {`
	`1094`	`+ if ((state[kState] & (kBuffered \| kOnFinished)) !== 0 && (state[kState] & kDestroyed) === 0) {`
`1095`	`1095`	`process.nextTick(errorBuffer, state);`
`1096`	`1096`	`}`
`1097`	`1097`