src: fix incorrect SIGSEGV handling in NODE_USE_V8_WASM_TRAP_HANDLER

korniltsev · nodejs-github-bot · commit ff028016ffd1 · 2020-09-26T10:30:39.000Z
Pass SA_SIGINFO to sa_flags so the TrapWebAssemblyOrContinue is treated as sa_sigaction, not sa_handler, otherwise siginfo_t* info contains some garbage PR-URL: #35282 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
diff --git a/src/node.cc b/src/node.cc
@@ -661,6 +661,7 @@ inline void PlatformInit() {
     struct sigaction sa;
     memset(&sa, 0, sizeof(sa));
     sa.sa_sigaction = TrapWebAssemblyOrContinue;
+    sa.sa_flags = SA_SIGINFO;
     CHECK_EQ(sigaction(SIGSEGV, &sa, nullptr), 0);
   }
 #endif  // defined(_WIN32)

Original file line number	Diff line number	Diff line change
`@@ -661,6 +661,7 @@ inline void PlatformInit() {`
`661`	`661`	`struct sigaction sa;`
`662`	`662`	`memset(&sa, 0, sizeof(sa));`
`663`	`663`	`sa.sa_sigaction = TrapWebAssemblyOrContinue;`
	`664`	`+ sa.sa_flags = SA_SIGINFO;`
`664`	`665`	`CHECK_EQ(sigaction(SIGSEGV, &sa, nullptr), 0);`
`665`	`666`	`}`
`666`	`667`	`#endif // defined(_WIN32)`