From 2fd45da1fce902a105327c2c591f411a524e932a Mon Sep 17 00:00:00 2001 From: alejandro Date: Tue, 7 Mar 2017 16:25:58 +0000 Subject: [PATCH] Preallocate array with buffer length subsystem: buffer Because the final array length is known, it's better to allocate its final length at initialization time to avoid future reallocations. It also adds an explicit buffer length greater than 0 comparison so it's more readable, avoids the internal ToBoolean call and follows the standard Node.js API format (as it can be checked in other similar structures where 'length > 0' is preferred over 'length') --- lib/buffer.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/buffer.js b/lib/buffer.js index d4f6ccff7e2fe2..83219dcff3aaba 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -810,8 +810,8 @@ Buffer.prototype.write = function(string, offset, length, encoding) { Buffer.prototype.toJSON = function() { - if (this.length) { - const data = []; + if (this.length > 0) { + const data = new Array(this.length); for (var i = 0; i < this.length; ++i) data[i] = this[i]; return { type: 'Buffer', data };