From e8feb30e9ec7172462066a9b42166379f32b7522 Mon Sep 17 00:00:00 2001 From: Yang-Kichang Date: Fri, 22 Sep 2017 15:37:01 +0900 Subject: [PATCH 1/2] change var name 'u' in line 97 I think using var name 'objUrl' is better then 'u'... --- lib/url.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/url.js b/lib/url.js index 887f5c29ce5a68..b67b57303b0267 100644 --- a/lib/url.js +++ b/lib/url.js @@ -94,9 +94,9 @@ const querystring = require('querystring'); function urlParse(url, parseQueryString, slashesDenoteHost) { if (url instanceof Url) return url; - var u = new Url(); - u.parse(url, parseQueryString, slashesDenoteHost); - return u; + var objUrl = new Url(); + objUrl.parse(url, parseQueryString, slashesDenoteHost); + return objUrl; } Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) { From e1f377f508f2eb0d2d06a33ae5e3afb09d3536ca Mon Sep 17 00:00:00 2001 From: Yang-Kichang Date: Fri, 22 Sep 2017 16:21:46 +0900 Subject: [PATCH 2/2] change objUrl to urlObject. --- lib/url.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/url.js b/lib/url.js index b67b57303b0267..b1e0ff8da56014 100644 --- a/lib/url.js +++ b/lib/url.js @@ -94,9 +94,9 @@ const querystring = require('querystring'); function urlParse(url, parseQueryString, slashesDenoteHost) { if (url instanceof Url) return url; - var objUrl = new Url(); - objUrl.parse(url, parseQueryString, slashesDenoteHost); - return objUrl; + var urlObject = new Url(); + urlObject.parse(url, parseQueryString, slashesDenoteHost); + return urlObject; } Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {