From eb12f6fe6cd170cdde0d85038574650cadfc9028 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Tue, 12 Sep 2017 14:45:32 -0400 Subject: [PATCH 1/3] build: ignore C4251 "mismatched dll-interface" --- common.gypi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index 598ba76d55ef69..de4f3a4184fbb1 100644 --- a/common.gypi +++ b/common.gypi @@ -205,7 +205,12 @@ # Disable "warning C4267: conversion from 'size_t' to 'int', # possible loss of data". Many originate from our dependencies # and their sheer number drowns out other, more legitimate warnings. - 'DisableSpecificWarnings': ['4267'], + # + # Disable "warning C4251: 'identifier' : class 'type' needs to have dll-interface to be used by clients of class 'type2'" + # Many V8 method do not comply with the requirements to be dll exported, + # which result in this warning reported several 1000s times. + # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251 + 'DisableSpecificWarnings': ['4267', '4251'], 'WarnAsError': 'false', }, 'VCLibrarianTool': { @@ -238,7 +243,7 @@ 'SuppressStartupBanner': 'true', }, }, - 'msvs_disabled_warnings': [4351, 4355, 4800], + 'msvs_disabled_warnings': [4351, 4355, 4800 ], 'conditions': [ ['asan == 1 and OS != "mac"', { 'cflags+': [ From 5b77d9476f78226413294325db1cae4d95160dcb Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Tue, 12 Sep 2017 14:55:55 -0400 Subject: [PATCH 2/3] build: ignore C4275 "bad inheritance dll-interface" --- common.gypi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index de4f3a4184fbb1..8df732642e6afd 100644 --- a/common.gypi +++ b/common.gypi @@ -207,10 +207,12 @@ # and their sheer number drowns out other, more legitimate warnings. # # Disable "warning C4251: 'identifier' : class 'type' needs to have dll-interface to be used by clients of class 'type2'" + # Disable "warning C4275: non - DLL-interface classkey 'identifier' used as base for DLL-interface classkey 'identifier'" # Many V8 method do not comply with the requirements to be dll exported, - # which result in this warning reported several 1000s times. + # which result in these warnings reported several 1000s times. # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251 - 'DisableSpecificWarnings': ['4267', '4251'], + # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275 + 'DisableSpecificWarnings': ['4267', '4251', '4275'], 'WarnAsError': 'false', }, 'VCLibrarianTool': { From eeda0e570ba535c6f0ed0741bc0d776271469ca3 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Wed, 18 Oct 2017 17:06:48 -0400 Subject: [PATCH 3/3] [test balloon] --- common.gypi | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/common.gypi b/common.gypi index 8df732642e6afd..a2c29b4b4b2aab 100644 --- a/common.gypi +++ b/common.gypi @@ -205,14 +205,7 @@ # Disable "warning C4267: conversion from 'size_t' to 'int', # possible loss of data". Many originate from our dependencies # and their sheer number drowns out other, more legitimate warnings. - # - # Disable "warning C4251: 'identifier' : class 'type' needs to have dll-interface to be used by clients of class 'type2'" - # Disable "warning C4275: non - DLL-interface classkey 'identifier' used as base for DLL-interface classkey 'identifier'" - # Many V8 method do not comply with the requirements to be dll exported, - # which result in these warnings reported several 1000s times. - # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251 - # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275 - 'DisableSpecificWarnings': ['4267', '4251', '4275'], + 'DisableSpecificWarnings': ['4267'], 'WarnAsError': 'false', }, 'VCLibrarianTool': { @@ -286,7 +279,6 @@ '_CRT_NONSTDC_NO_DEPRECATE', # Make sure the STL doesn't try to use exceptions '_HAS_EXCEPTIONS=0', - 'BUILDING_V8_SHARED=1', 'BUILDING_UV_SHARED=1', ], }],