From e010f9cc38b8faf8dd1a3781902b18eb7b70bec7 Mon Sep 17 00:00:00 2001 From: Paul Berry Date: Fri, 6 Oct 2017 10:22:27 -0700 Subject: [PATCH 1/5] test: replace fixturesdir use common.fixtures --- test/parallel/test-http2-respond-file-fd.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-http2-respond-file-fd.js b/test/parallel/test-http2-respond-file-fd.js index 29a5fe665deb92..e0f9d7f05798ee 100644 --- a/test/parallel/test-http2-respond-file-fd.js +++ b/test/parallel/test-http2-respond-file-fd.js @@ -1,6 +1,7 @@ 'use strict'; const common = require('../common'); +const fixtures = require('../common/fixtures'); if (!common.hasCrypto) common.skip('missing crypto'); const http2 = require('http2'); @@ -13,7 +14,8 @@ const { HTTP2_HEADER_CONTENT_LENGTH } = http2.constants; -const fname = path.resolve(common.fixturesDir, 'elipses.txt'); +const fname = path.resolve(fixtures.fixturesDir, 'elipses.txt'); + const data = fs.readFileSync(fname); const stat = fs.statSync(fname); const fd = fs.openSync(fname, 'r'); From c117347108390489679a792dadac68d019bf6b89 Mon Sep 17 00:00:00 2001 From: Paul Berry Date: Fri, 6 Oct 2017 10:53:26 -0700 Subject: [PATCH 2/5] test: replace fixturesdir use common.fixtures --- test/parallel/test-http2-respond-file-fd.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-http2-respond-file-fd.js b/test/parallel/test-http2-respond-file-fd.js index e0f9d7f05798ee..5aa2ec486c8382 100644 --- a/test/parallel/test-http2-respond-file-fd.js +++ b/test/parallel/test-http2-respond-file-fd.js @@ -14,7 +14,7 @@ const { HTTP2_HEADER_CONTENT_LENGTH } = http2.constants; -const fname = path.resolve(fixtures.fixturesDir, 'elipses.txt'); +const fname = path.resolve(fixtures.path(), 'elipses.txt'); const data = fs.readFileSync(fname); const stat = fs.statSync(fname); From 86dd0dc5ac5c01d4f077b53d5e8c3dedbfa82a8c Mon Sep 17 00:00:00 2001 From: Paul Berry Date: Fri, 6 Oct 2017 12:03:31 -0700 Subject: [PATCH 3/5] test: replace resolve use path method --- test/parallel/test-http2-respond-file-fd.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-http2-respond-file-fd.js b/test/parallel/test-http2-respond-file-fd.js index 5aa2ec486c8382..6b9fbec424672f 100644 --- a/test/parallel/test-http2-respond-file-fd.js +++ b/test/parallel/test-http2-respond-file-fd.js @@ -14,7 +14,7 @@ const { HTTP2_HEADER_CONTENT_LENGTH } = http2.constants; -const fname = path.resolve(fixtures.path(), 'elipses.txt'); +const fname = fixtures.path('elipses.txt'); const data = fs.readFileSync(fname); const stat = fs.statSync(fname); From 5f5da5829604e1f336883abf6c1fc12ef6eb1742 Mon Sep 17 00:00:00 2001 From: Paul Berry Date: Sat, 7 Oct 2017 13:03:20 -0700 Subject: [PATCH 4/5] test: remove unused var path --- test/parallel/test-http2-respond-file-fd.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/parallel/test-http2-respond-file-fd.js b/test/parallel/test-http2-respond-file-fd.js index 6b9fbec424672f..1bfc48f1c60243 100644 --- a/test/parallel/test-http2-respond-file-fd.js +++ b/test/parallel/test-http2-respond-file-fd.js @@ -6,7 +6,6 @@ if (!common.hasCrypto) common.skip('missing crypto'); const http2 = require('http2'); const assert = require('assert'); -const path = require('path'); const fs = require('fs'); const { From 963a8336b2584075263cf0e8fa3f08d26dd08678 Mon Sep 17 00:00:00 2001 From: Paul Berry Date: Sat, 7 Oct 2017 14:41:11 -0700 Subject: [PATCH 5/5] test: removal of new line --- test/parallel/test-http2-respond-file-fd.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/parallel/test-http2-respond-file-fd.js b/test/parallel/test-http2-respond-file-fd.js index 1bfc48f1c60243..303d25be3f2b66 100644 --- a/test/parallel/test-http2-respond-file-fd.js +++ b/test/parallel/test-http2-respond-file-fd.js @@ -14,7 +14,6 @@ const { } = http2.constants; const fname = fixtures.path('elipses.txt'); - const data = fs.readFileSync(fname); const stat = fs.statSync(fname); const fd = fs.openSync(fname, 'r');