From bd010be841330991f37f0080ae6af7f0fc006099 Mon Sep 17 00:00:00 2001 From: twk-b Date: Fri, 6 Oct 2017 14:03:53 -0600 Subject: [PATCH 1/2] test: improved assert.strictEqual message to include actual values --- test/parallel/test-domain-http-server.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-domain-http-server.js b/test/parallel/test-domain-http-server.js index 99000563eba8c8..acb2a829c5adc2 100644 --- a/test/parallel/test-domain-http-server.js +++ b/test/parallel/test-domain-http-server.js @@ -109,7 +109,7 @@ function next() { } process.on('exit', function() { - assert.strictEqual(serverCaught, 2); - assert.strictEqual(clientCaught, 2); + assert.strictEqual(serverCaught, 2, `Expected value was 2, but actual value was ${serverCaught}`); + assert.strictEqual(clientCaught, 2, `Expected value was 2, but actual value was ${clientCaught}`); console.log('ok'); }); From 78fb1336d3e06276478630c33bc8166368ad8ae9 Mon Sep 17 00:00:00 2001 From: Bernie Lees Date: Fri, 13 Oct 2017 16:06:12 -0600 Subject: [PATCH 2/2] improve assert failure message in parallel/test-domain-http-server failure cases to include actual value with more meaningufl message --- test/parallel/test-domain-http-server.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-domain-http-server.js b/test/parallel/test-domain-http-server.js index acb2a829c5adc2..43b8d5d3809e17 100644 --- a/test/parallel/test-domain-http-server.js +++ b/test/parallel/test-domain-http-server.js @@ -51,7 +51,7 @@ const server = http.createServer(function(req, res) { const data = JSON.stringify(objects[req.url.replace(/[^a-z]/g, '')]); // this line will throw if you pick an unknown key - assert.notStrictEqual(data, undefined, 'Data should not be undefined'); + assert.notStrictEqual(data, undefined); res.writeHead(200); res.end(data); @@ -109,7 +109,7 @@ function next() { } process.on('exit', function() { - assert.strictEqual(serverCaught, 2, `Expected value was 2, but actual value was ${serverCaught}`); - assert.strictEqual(clientCaught, 2, `Expected value was 2, but actual value was ${clientCaught}`); + assert.strictEqual(serverCaught, 2); + assert.strictEqual(clientCaught, 2); console.log('ok'); });