From ffc04cfb7d5bd53a690c581cccfed4c6b5d28175 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Sat, 21 Oct 2017 11:25:43 +0200 Subject: [PATCH] test: mark big string tests flaky on freebsd Some of the addons/stringbytes-external-exceed-max tests are known flaky after the upgrade to V8 6.2. The most likely reason is the increase of the maximum string length from 256 to 1024 MB, pushing their execution times over the time limit. Fixes: https://github.com/nodejs/node/issues/16354 Refs: https://github.com/nodejs/node/pull/15362 --- test/addons/addons.status | 10 ++++++++++ test/addons/testcfg.py | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 test/addons/addons.status diff --git a/test/addons/addons.status b/test/addons/addons.status new file mode 100644 index 00000000000000..749648635a6602 --- /dev/null +++ b/test/addons/addons.status @@ -0,0 +1,10 @@ +prefix addons + +# https://github.com/nodejs/node/issues/16354 - known flaky after the upgrade +# to V8 6.2 in https://github.com/nodejs/node/pull/15362. Most likely reason +# is the increase of the maximum string length from 256 to 1024 MB, pushing +# their execution times over the time limit. +[$system==freebsd] +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary: FLAKY,PASS +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex: FLAKY,PASS +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max: FLAKY,PASS diff --git a/test/addons/testcfg.py b/test/addons/testcfg.py index 908fd6a475cc39..6c61081fbb0bac 100644 --- a/test/addons/testcfg.py +++ b/test/addons/testcfg.py @@ -3,4 +3,4 @@ import testpy def GetConfiguration(context, root): - return testpy.AddonTestConfiguration(context, root, 'addon') + return testpy.AddonTestConfiguration(context, root, 'addons')