From 81cfdc6ee0977d223e2e59394f8f98eaf8357b4c Mon Sep 17 00:00:00 2001 From: Paul Ashfield Date: Mon, 6 Nov 2017 15:32:35 +0000 Subject: [PATCH 1/3] Nodeconf is awesome first change --- test/addons-napi/test_general/testNapiRun.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/test/addons-napi/test_general/testNapiRun.js b/test/addons-napi/test_general/testNapiRun.js index d7534ecf9c3912..5b69e88fd8ce19 100644 --- a/test/addons-napi/test_general/testNapiRun.js +++ b/test/addons-napi/test_general/testNapiRun.js @@ -7,6 +7,10 @@ const assert = require('assert'); // eslint-disable-next-line no-unused-vars const addon = require(`./build/${common.buildType}/test_general`); -assert.strictEqual(addon.testNapiRun('(41.92 + 0.08);'), 42, - 'napi_run_script() works correctly'); -assert.throws(() => addon.testNapiRun({ abc: 'def' }), /string was expected/); +const args = [41.92, 0.08]; +const testCase = '(' + args.join(' + ') + ');'; +const expected = 43; +const actual = addon.testNapiRun(testCase); + +assert.strictEqual(actual, expected, `testNapiRun${testCase} gets ${actual} not expected ${expected}`); +assert.throws(() => addon.testNapiRun({abc: 'def'}), /string was expected/); \ No newline at end of file From a9d7c3d5b49b094cba3c5b95221bca014bba03a9 Mon Sep 17 00:00:00 2001 From: Paul Ashfield Date: Tue, 7 Nov 2017 10:30:46 +0000 Subject: [PATCH 2/3] Updated test case based on feedback from @apapirovski @vsemozhetbyt and Gireesh - thanks all --- test/addons-napi/test_general/testNapiRun.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/test/addons-napi/test_general/testNapiRun.js b/test/addons-napi/test_general/testNapiRun.js index 5b69e88fd8ce19..5b784a8883daf2 100644 --- a/test/addons-napi/test_general/testNapiRun.js +++ b/test/addons-napi/test_general/testNapiRun.js @@ -7,10 +7,9 @@ const assert = require('assert'); // eslint-disable-next-line no-unused-vars const addon = require(`./build/${common.buildType}/test_general`); -const args = [41.92, 0.08]; -const testCase = '(' + args.join(' + ') + ');'; -const expected = 43; +const testCase = '(41.92 + 0.08);'; +const expected = 42; const actual = addon.testNapiRun(testCase); -assert.strictEqual(actual, expected, `testNapiRun${testCase} gets ${actual} not expected ${expected}`); -assert.throws(() => addon.testNapiRun({abc: 'def'}), /string was expected/); \ No newline at end of file +assert.strictEqual(actual, expected); +assert.throws(() => addon.testNapiRun({abc: 'def'}), /string was expected/); From 2b1ad0aa44cb362455d7e14f3cb9a8d5dbfba64b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 8 Nov 2017 12:28:56 +0000 Subject: [PATCH 3/3] squash: lint fix --- test/addons-napi/test_general/testNapiRun.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/addons-napi/test_general/testNapiRun.js b/test/addons-napi/test_general/testNapiRun.js index 5b784a8883daf2..af9f89fa29d53d 100644 --- a/test/addons-napi/test_general/testNapiRun.js +++ b/test/addons-napi/test_general/testNapiRun.js @@ -12,4 +12,4 @@ const expected = 42; const actual = addon.testNapiRun(testCase); assert.strictEqual(actual, expected); -assert.throws(() => addon.testNapiRun({abc: 'def'}), /string was expected/); +assert.throws(() => addon.testNapiRun({ abc: 'def' }), /string was expected/);