From 5130f991714d0913041b44be989083d347cef105 Mon Sep 17 00:00:00 2001 From: Hackzzila Date: Tue, 7 Nov 2017 22:55:39 -0600 Subject: [PATCH 1/2] doc: deprecate top-level this being bound to module.exports Fixes: https://github.com/nodejs/node/issues/9623 --- doc/api/deprecations.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 8f94f6b248fe82..236cf33a70550e 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -737,6 +737,14 @@ Type: Runtime internal mechanics of the `REPLServer` itself, and is therefore not necessary in user space. + +### DEP0083: Top-level `this` bound to `module.exports` + +Type: Documentation-only + +Assigning properties to the top-level `this` as an alternative +to `module.exports` is deprecated. Developers should use `exports` +or `module.exports` instead. [`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size [`Buffer.from(array)`]: buffer.html#buffer_class_method_buffer_from_array From 8d0a3beade16918f09720efe1e85da2277995a17 Mon Sep 17 00:00:00 2001 From: Hackzzila Date: Wed, 8 Nov 2017 08:28:34 -0600 Subject: [PATCH 2/2] doc: change title to DEP00XX --- doc/api/deprecations.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 236cf33a70550e..83e39eed0d2922 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -737,8 +737,8 @@ Type: Runtime internal mechanics of the `REPLServer` itself, and is therefore not necessary in user space. - -### DEP0083: Top-level `this` bound to `module.exports` + +### DEP00XX: Top-level `this` bound to `module.exports` Type: Documentation-only