From ad7608f8e9b579dfe00cd24acb1d3483d9100fb7 Mon Sep 17 00:00:00 2001 From: Mandeep Singh Date: Sun, 26 Nov 2017 19:29:34 +0530 Subject: [PATCH 1/3] test: Update test-http-parser-free to use countdown timer Fixes: https://github.com/nodejs/node/issues/17169 --- test/parallel/test-http-parser-free.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-http-parser-free.js b/test/parallel/test-http-parser-free.js index 1ead3c14928d88..4afa25790e740e 100644 --- a/test/parallel/test-http-parser-free.js +++ b/test/parallel/test-http-parser-free.js @@ -23,13 +23,16 @@ require('../common'); const assert = require('assert'); const http = require('http'); +const Countdown = require('../common/countdown'); const N = 100; -let responses = 0; +const responses = 0; const server = http.createServer(function(req, res) { res.end('Hello'); }); +const countdown = new Countdown(N, () => server.close()); + server.listen(0, function() { http.globalAgent.maxSockets = 1; let parser; @@ -42,9 +45,7 @@ server.listen(0, function() { assert.strictEqual(req.parser, parser); } - if (++responses === N) { - server.close(); - } + countdown.dec(); res.resume(); }); })(i); From f687f362e5aef3f1eb5aa2ce9ec1fa4670324b7d Mon Sep 17 00:00:00 2001 From: Mandeep Singh Date: Sun, 26 Nov 2017 19:55:33 +0530 Subject: [PATCH 2/3] squash: change assert logic --- test/parallel/test-http-parser-free.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/parallel/test-http-parser-free.js b/test/parallel/test-http-parser-free.js index 4afa25790e740e..ab5395bf4ac879 100644 --- a/test/parallel/test-http-parser-free.js +++ b/test/parallel/test-http-parser-free.js @@ -25,7 +25,6 @@ const assert = require('assert'); const http = require('http'); const Countdown = require('../common/countdown'); const N = 100; -const responses = 0; const server = http.createServer(function(req, res) { res.end('Hello'); @@ -53,5 +52,5 @@ server.listen(0, function() { }); process.on('exit', function() { - assert.strictEqual(responses, N); + assert.strictEqual(0, countdown.remaining); }); From 5b4c6ed52d4a76babd7392c142286b1a14a894de Mon Sep 17 00:00:00 2001 From: Mandeep Singh Date: Sun, 26 Nov 2017 22:20:08 +0530 Subject: [PATCH 3/3] squash: remove process exit event --- test/parallel/test-http-parser-free.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/parallel/test-http-parser-free.js b/test/parallel/test-http-parser-free.js index ab5395bf4ac879..935d4d2ef443b0 100644 --- a/test/parallel/test-http-parser-free.js +++ b/test/parallel/test-http-parser-free.js @@ -50,7 +50,3 @@ server.listen(0, function() { })(i); } }); - -process.on('exit', function() { - assert.strictEqual(0, countdown.remaining); -});