diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js index 8c4d38ea8264ae..4186032ac7fcdc 100644 --- a/test/parallel/test-assert.js +++ b/test/parallel/test-assert.js @@ -614,7 +614,6 @@ testAssertionMessage({ a: undefined, b: null }, '{ a: undefined, b: null }'); testAssertionMessage({ a: NaN, b: Infinity, c: -Infinity }, '{ a: NaN, b: Infinity, c: -Infinity }'); -// #2893 { let threw = false; try { @@ -629,7 +628,6 @@ testAssertionMessage({ a: NaN, b: Infinity, c: -Infinity }, assert.ok(threw); } -// #5292 try { assert.strictEqual(1, 2); } catch (e) { diff --git a/test/parallel/test-whatwg-url-setters.js b/test/parallel/test-whatwg-url-setters.js index 7655e4a2578bb1..c5482889b18c7a 100644 --- a/test/parallel/test-whatwg-url-setters.js +++ b/test/parallel/test-whatwg-url-setters.js @@ -32,7 +32,7 @@ function startURLSettersTests() { // request.send() // request.responseType = "json" // request.onload = setup.step_func(function() { - runURLSettersTests(request.response) + runURLSettersTests(request.response); // setup.done() // }) // }) @@ -40,19 +40,19 @@ function startURLSettersTests() { function runURLSettersTests(all_test_cases) { for (var attribute_to_be_set in all_test_cases) { - if (attribute_to_be_set == "comment") { + if (attribute_to_be_set === 'comment') { continue; } var test_cases = all_test_cases[attribute_to_be_set]; for(var i = 0, l = test_cases.length; i < l; i++) { - var test_case = test_cases[i]; - var name = `Setting <${test_case.href}>.${attribute_to_be_set}` + + const test_case = test_cases[i]; + let name = `Setting <${test_case.href}>.${attribute_to_be_set}` + ` = '${test_case.new_value}'`; - if ("comment" in test_case) { + if ('comment' in test_case) { name += ` ${test_case.comment}`; } test(function() { - var url = new URL(test_case.href); + const url = new URL(test_case.href); url[attribute_to_be_set] = test_case.new_value; for (var attribute in test_case.expected) { assert_equals(url[attribute], test_case.expected[attribute]) @@ -78,7 +78,7 @@ function runURLSettersTests(all_test_cases) { } } -startURLSettersTests() +startURLSettersTests(); /* eslint-enable */ // Tests below are not from WPT.