From 45a938ad4e5965131c222984055b35f19573b6af Mon Sep 17 00:00:00 2001 From: ryanmahan Date: Fri, 19 Jan 2018 15:06:58 -0500 Subject: [PATCH 1/2] test: change assert message to default assert.strictEqual message argument removed to replace with default assert message to show the expected vs actual values Refs: https://github.com/nodejs/node/issues/13296 --- test/known_issues/test-http-path-contains-unicode.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/known_issues/test-http-path-contains-unicode.js b/test/known_issues/test-http-path-contains-unicode.js index 68b66b7c6940ed..e1954257a89f86 100644 --- a/test/known_issues/test-http-path-contains-unicode.js +++ b/test/known_issues/test-http-path-contains-unicode.js @@ -10,10 +10,10 @@ const http = require('http'); const expected = '/café🐶'; +//Sanity check for café🐶 is café🐶 assert.strictEqual( expected, - '/caf\u{e9}\u{1f436}', - 'Sanity check that string literal produced the expected string' + '/caf\u{e9}\u{1f436}' ); const server = http.createServer(common.mustCall(function(req, res) { From 7d6a2f6ab7edccc4cff11f64eca8f91797f98bd9 Mon Sep 17 00:00:00 2001 From: Ryan Mahan Date: Fri, 19 Jan 2018 16:29:09 -0500 Subject: [PATCH 2/2] Corrections for PR comments Condensed line 14 assert to one line --- test/known_issues/test-http-path-contains-unicode.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/known_issues/test-http-path-contains-unicode.js b/test/known_issues/test-http-path-contains-unicode.js index e1954257a89f86..10d6b74d53993d 100644 --- a/test/known_issues/test-http-path-contains-unicode.js +++ b/test/known_issues/test-http-path-contains-unicode.js @@ -11,10 +11,7 @@ const http = require('http'); const expected = '/café🐶'; //Sanity check for café🐶 is café🐶 -assert.strictEqual( - expected, - '/caf\u{e9}\u{1f436}' -); +assert.strictEqual('/caf\u{e9}\u{1f436}', expected); const server = http.createServer(common.mustCall(function(req, res) { assert.strictEqual(req.url, expected);