From 7530d94a31a1f7d2b61a48384bfff8db29ada0bc Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Fri, 2 Feb 2018 10:33:01 -0500 Subject: [PATCH 1/2] doc: remove usage of you in n-api doc We avoid using 'you' in the documentation based on our guidelines. Remove usage in the n-api doc. --- doc/api/n-api.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/n-api.md b/doc/api/n-api.md index 05e799cc0e550b..b222143e23059c 100644 --- a/doc/api/n-api.md +++ b/doc/api/n-api.md @@ -3148,7 +3148,7 @@ Afterward, additional manipulation of the wrapper's prototype chain may cause *Note*: Calling `napi_wrap()` a second time on an object that already has a native instance associated with it by virtue of a previous call to -`napi_wrap()` will cause an error to be returned. If you wish to associate +`napi_wrap()` will cause an error to be returned. In order to associate another native instance with the given object, call `napi_remove_wrap()` on it first. From 3cded131e76bc3c59200ef03f39af1331c50bbfb Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 5 Feb 2018 10:02:47 -0500 Subject: [PATCH 2/2] squash: address comments --- doc/api/n-api.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/doc/api/n-api.md b/doc/api/n-api.md index b222143e23059c..ca8f1a73a7b1c7 100644 --- a/doc/api/n-api.md +++ b/doc/api/n-api.md @@ -3146,11 +3146,8 @@ required in order to enable correct proper of the reference. Afterward, additional manipulation of the wrapper's prototype chain may cause `napi_unwrap()` to fail. -*Note*: Calling `napi_wrap()` a second time on an object that already has a -native instance associated with it by virtue of a previous call to -`napi_wrap()` will cause an error to be returned. In order to associate -another native instance with the given object, call `napi_remove_wrap()` on it -first. +Calling napi_wrap() a second time on an object will return an error. To associate +another native instance with the object, use napi_remove_wrap() first. ### napi_unwrap