From b2034be1813f1d91dc50cc546104f0192650f127 Mon Sep 17 00:00:00 2001 From: Joseph Gordon Date: Fri, 9 Feb 2018 18:41:48 -0600 Subject: [PATCH 1/3] doc: improved flow regarding firewall script for macOS in building readme --- BUILDING.md | 12 +++++++----- tools/remark-cli/package-lock.json | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 4a93b37efa4b0f..48656636a39027 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -124,18 +124,20 @@ On macOS, you will need to install the `Xcode Command Line Tools` by running installed, you can find them under the menu `Xcode -> Open Developer Tool -> More Developer Tools...`. This step will install `clang`, `clang++`, and `make`. -* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) -to avoid popups asking to accept incoming network connections when running -tests: If the path to your build directory contains a space, the build will likely fail. +After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) +to avoid popups asking to accept incoming network connections when running tests. + +Running this script on macOS + ```console $ sudo ./tools/macosx-firewall.sh ``` -Running this script will add rules for the executable `node` in the `out` -directory and the symbolic `node` link in the project's root directory. +will add the firewall rules for the executable `node` in the `out` directory and +the symbolic `node` link in the project's root directory. On FreeBSD and OpenBSD, you may also need: * libexecinfo diff --git a/tools/remark-cli/package-lock.json b/tools/remark-cli/package-lock.json index e47a22823d9e8f..f8ed41f779bdea 100644 --- a/tools/remark-cli/package-lock.json +++ b/tools/remark-cli/package-lock.json @@ -2,7 +2,6 @@ "name": "remark-cli", "version": "4.0.0", "lockfileVersion": 1, - "preserveSymlinks": "1", "requires": true, "dependencies": { "ansi-regex": { From a6514576534c09525b1bb18a0e23744d858c4832 Mon Sep 17 00:00:00 2001 From: Joseph Gordon Date: Tue, 20 Feb 2018 13:18:09 -0600 Subject: [PATCH 2/3] doc: incorporated suggestion from code review --- BUILDING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 48656636a39027..9010a4b6965e9b 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -128,8 +128,8 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and If the path to your build directory contains a space, the build will likely fail. -After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) -to avoid popups asking to accept incoming network connections when running tests. +After building, setting up [filewall rules](tools/macosx-firewall.sh) can avoid popups +asking to accept incoming network connections when running tests. Running this script on macOS From 4533b9f65b7fa1a6bbbace3a8131f133b1830210 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Tue, 10 Apr 2018 02:42:20 +0200 Subject: [PATCH 3/3] fixup: add suggestions --- BUILDING.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 9010a4b6965e9b..d5f638b3616265 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -128,16 +128,16 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and If the path to your build directory contains a space, the build will likely fail. -After building, setting up [filewall rules](tools/macosx-firewall.sh) can avoid popups -asking to accept incoming network connections when running tests. +After building, setting up [firewall rules](tools/macosx-firewall.sh) can avoid +popups asking to accept incoming network connections when running tests. -Running this script on macOS +Running the following script on macOS will add the firewall rules for the +executable `node` in the `out` directory and the symbolic `node` link in the +project's root directory. ```console $ sudo ./tools/macosx-firewall.sh ``` -will add the firewall rules for the executable `node` in the `out` directory and -the symbolic `node` link in the project's root directory. On FreeBSD and OpenBSD, you may also need: * libexecinfo