From 8c825268728128c070fbeea5c34fa2c01a74be86 Mon Sep 17 00:00:00 2001 From: Justin Lee Date: Mon, 19 Feb 2018 21:55:35 -0800 Subject: [PATCH 1/5] Fixed broken link in onboarding.md. Removed Members team link. --- doc/onboarding.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 7f262e26665906..77dea759c13fea 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -14,9 +14,8 @@ onboarding session. ## Fifteen minutes before the onboarding session -* Prior to the onboarding session, add the new Collaborator to - [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators), - and to [the Members team](https://github.com/orgs/nodejs/teams/members) if +* Prior to the onboarding session, add the new Collaborator to the + [the Collaborators team](https://github.com/nodejs/node#collaborators), if they are not already part of it. Note that this is the step that gives the account elevated privileges, so do not perform this step (or any subsequent steps) unless two-factor authentication is enabled on the new Collaborator's From a302929500550416f9beed15a92d0ac09ed9769d Mon Sep 17 00:00:00 2001 From: Justin Lee Date: Tue, 20 Feb 2018 07:15:40 -0800 Subject: [PATCH 2/5] Reverted link back to nodejs/team/collaborators --- doc/onboarding.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 77dea759c13fea..c3a8d7e4a3ecab 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -15,7 +15,7 @@ onboarding session. ## Fifteen minutes before the onboarding session * Prior to the onboarding session, add the new Collaborator to the - [the Collaborators team](https://github.com/nodejs/node#collaborators), if + [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators), if they are not already part of it. Note that this is the step that gives the account elevated privileges, so do not perform this step (or any subsequent steps) unless two-factor authentication is enabled on the new Collaborator's From 216f86adcd319b912f25f2467e8f98bbf8f5bf06 Mon Sep 17 00:00:00 2001 From: Justin Lee Date: Tue, 20 Feb 2018 13:48:04 -0800 Subject: [PATCH 3/5] Fixed typo --- doc/onboarding.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index c3a8d7e4a3ecab..5347fe1bce082f 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -14,7 +14,7 @@ onboarding session. ## Fifteen minutes before the onboarding session -* Prior to the onboarding session, add the new Collaborator to the +* Prior to the onboarding session, add the new Collaborator to [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators), if they are not already part of it. Note that this is the step that gives the account elevated privileges, so do not perform this step (or any subsequent From de0085be8359a0ed1150016e1d82c22af30c9732 Mon Sep 17 00:00:00 2001 From: Justin Lee Date: Tue, 20 Feb 2018 13:49:03 -0800 Subject: [PATCH 4/5] Removed comma, as requested --- doc/onboarding.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 5347fe1bce082f..3659eed52709bc 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -15,7 +15,7 @@ onboarding session. ## Fifteen minutes before the onboarding session * Prior to the onboarding session, add the new Collaborator to - [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators), if + [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators) if they are not already part of it. Note that this is the step that gives the account elevated privileges, so do not perform this step (or any subsequent steps) unless two-factor authentication is enabled on the new Collaborator's From 9ba29534d5f1bd1431cba551c7caa8abb4c5b3fc Mon Sep 17 00:00:00 2001 From: Justin Lee Date: Tue, 20 Feb 2018 14:07:44 -0800 Subject: [PATCH 5/5] Removed 'if they are not already part of it' --- doc/onboarding.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 3659eed52709bc..352a181f4dce8e 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -15,11 +15,10 @@ onboarding session. ## Fifteen minutes before the onboarding session * Prior to the onboarding session, add the new Collaborator to - [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators) if - they are not already part of it. Note that this is the step that gives the - account elevated privileges, so do not perform this step (or any subsequent - steps) unless two-factor authentication is enabled on the new Collaborator's - GitHub account. + [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators). + Note that this is the step that gives the account elevated privileges, so do + not perform this step (or any subsequent steps) unless two-factor + authentication is enabled on the new Collaborator's GitHub account. ## Onboarding session