From 1e2329f21ce35026b2bb7bada9629f99abe49483 Mon Sep 17 00:00:00 2001 From: Snehil Verma Date: Sun, 8 Apr 2018 23:03:00 +0530 Subject: [PATCH 1/7] changed comment that was wrong in _steram_readable.js --- lib/_stream_readable.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 5b044e79c1b18d..3d5f6ec43972e0 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -302,7 +302,8 @@ function chunkInvalid(state, chunk) { } -// if it's past the high water mark, we can push in some more. +// It simply checks the the state length with high water mark +// which will return true if we are below the watermark // Also, if we have no data yet, we can stand some // more bytes. This is to work around cases where hwm=0, // such as the repl. Also, if the push() triggered a From d7889ca9b60ef88287af40d7f6a35389f9284420 Mon Sep 17 00:00:00 2001 From: Snehil Verma Date: Mon, 9 Apr 2018 16:06:04 +0530 Subject: [PATCH 2/7] updated comment and corrected the typo --- lib/_stream_readable.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 3d5f6ec43972e0..34655175240a74 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -302,8 +302,9 @@ function chunkInvalid(state, chunk) { } -// It simply checks the the state length with high water mark -// which will return true if we are below the watermark +// It simply checks the state length with high water mark +// which will return true if we are below the watermark. +// We can also push more code if were past the highWaterMark. // Also, if we have no data yet, we can stand some // more bytes. This is to work around cases where hwm=0, // such as the repl. Also, if the push() triggered a From 411966c258ddc97a10e883cddfb3eceebd5f316d Mon Sep 17 00:00:00 2001 From: Snehil Verma Date: Mon, 9 Apr 2018 16:40:13 +0530 Subject: [PATCH 3/7] updated comment --- lib/_stream_readable.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 34655175240a74..1816aded694f2b 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -303,7 +303,7 @@ function chunkInvalid(state, chunk) { // It simply checks the state length with high water mark -// which will return true if we are below the watermark. +// and will return true if we are below the watermark. // We can also push more code if were past the highWaterMark. // Also, if we have no data yet, we can stand some // more bytes. This is to work around cases where hwm=0, From 69d7d23f876ae606d2ad96766cd11c1b6f405dbe Mon Sep 17 00:00:00 2001 From: Snehil Verma Date: Mon, 9 Apr 2018 17:06:31 +0530 Subject: [PATCH 4/7] removed the updates and made it similar to previous one --- lib/_stream_readable.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 1816aded694f2b..98ffee62f6ba5e 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -302,9 +302,7 @@ function chunkInvalid(state, chunk) { } -// It simply checks the state length with high water mark -// and will return true if we are below the watermark. -// We can also push more code if were past the highWaterMark. +// We can push more code if were are below the highWaterMark. // Also, if we have no data yet, we can stand some // more bytes. This is to work around cases where hwm=0, // such as the repl. Also, if the push() triggered a From 21428511a5d65f8f190bc8002e8712749c3b71cd Mon Sep 17 00:00:00 2001 From: Snehil Verma Date: Mon, 9 Apr 2018 17:10:23 +0530 Subject: [PATCH 5/7] made grammatically correct --- lib/_stream_readable.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 98ffee62f6ba5e..2faaa2627c4b35 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -302,7 +302,7 @@ function chunkInvalid(state, chunk) { } -// We can push more code if were are below the highWaterMark. +// We can push more code if are below the highWaterMark. // Also, if we have no data yet, we can stand some // more bytes. This is to work around cases where hwm=0, // such as the repl. Also, if the push() triggered a From 4ea32346daebb7046f1b6d05a103221313d1cbb0 Mon Sep 17 00:00:00 2001 From: Snehil Verma Date: Mon, 9 Apr 2018 17:22:47 +0530 Subject: [PATCH 6/7] made grammatically correct --- lib/_stream_readable.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 2faaa2627c4b35..a24c14d3de4d1f 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -302,7 +302,7 @@ function chunkInvalid(state, chunk) { } -// We can push more code if are below the highWaterMark. +// We can push more code if we are below the highWaterMark. // Also, if we have no data yet, we can stand some // more bytes. This is to work around cases where hwm=0, // such as the repl. Also, if the push() triggered a From 8989b9abeb1d304a85d88e113f450924fece8740 Mon Sep 17 00:00:00 2001 From: Snehil Verma Date: Thu, 12 Apr 2018 20:35:47 +0530 Subject: [PATCH 7/7] updated code to data to make it clear --- lib/_stream_readable.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index a24c14d3de4d1f..8073e174cc586f 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -302,7 +302,7 @@ function chunkInvalid(state, chunk) { } -// We can push more code if we are below the highWaterMark. +// We can push more data if we are below the highWaterMark. // Also, if we have no data yet, we can stand some // more bytes. This is to work around cases where hwm=0, // such as the repl. Also, if the push() triggered a