From de5f13166102cb8fb1650add08f1e2a37b80dfc8 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Wed, 11 Apr 2018 03:47:27 +0200 Subject: [PATCH] tools: stricter no-undef eslint rule By default eslint does not validate variables that are placed in a typeof check. This caused a error that is fixed in this PR. --- .eslintrc.js | 2 +- lib/internal/fs.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 5c4933101447f2..2eb3eae6a88979 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -185,7 +185,7 @@ module.exports = { 'no-this-before-super': 'error', 'no-throw-literal': 'error', 'no-trailing-spaces': 'error', - 'no-undef': 'error', + 'no-undef': ['error', { typeof: true }], 'no-undef-init': 'error', 'no-unexpected-multiline': 'error', 'no-unreachable': 'error', diff --git a/lib/internal/fs.js b/lib/internal/fs.js index 6ff4152aa46814..848a11dae68a3e 100644 --- a/lib/internal/fs.js +++ b/lib/internal/fs.js @@ -350,7 +350,7 @@ function validateLen(len) { let err; if (!isInt32(len)) { - if (typeof value !== 'number') { + if (typeof len !== 'number') { err = new ERR_INVALID_ARG_TYPE('len', 'number', len); } else { // TODO(BridgeAR): Improve this error message.