From 4a1e88f940d9dcea7965e619264b0e82b5d22c65 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Tue, 17 Apr 2018 22:19:23 +0530 Subject: [PATCH] src: remove redundant calls to v8::HandleScope Remove redundant calls to v8::HandleScope in the contructor and destructor for the AsyncScope class Refs: https://github.com/nodejs/node/pull/19972#issuecomment-381353894 Refs: https://github.com/nodejs/node/pull/20045 --- src/async_wrap-inl.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/async_wrap-inl.h b/src/async_wrap-inl.h index f9c709aa21e987..c9f12333243092 100644 --- a/src/async_wrap-inl.h +++ b/src/async_wrap-inl.h @@ -50,7 +50,6 @@ inline AsyncWrap::AsyncScope::AsyncScope(AsyncWrap* wrap) Environment* env = wrap->env(); if (env->async_hooks()->fields()[Environment::AsyncHooks::kBefore] == 0) return; - v8::HandleScope handle_scope(env->isolate()); EmitBefore(env, wrap->get_async_id()); } @@ -58,7 +57,6 @@ inline AsyncWrap::AsyncScope::~AsyncScope() { Environment* env = wrap_->env(); if (env->async_hooks()->fields()[Environment::AsyncHooks::kAfter] == 0) return; - v8::HandleScope handle_scope(env->isolate()); EmitAfter(env, wrap_->get_async_id()); }