From 538ef2f3a66e11e80a0455faed8974327bbb3012 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Sat, 21 Apr 2018 00:51:33 +0530 Subject: [PATCH] src: remove redundant calls to HandleScope Refs: https://github.com/nodejs/node/pull/19972#issuecomment-381353894 Refs: https://github.com/nodejs/node/pull/20045 --- src/node.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/node.cc b/src/node.cc index 6acad6870d81da..a92dbd85aba247 100644 --- a/src/node.cc +++ b/src/node.cc @@ -930,7 +930,6 @@ InternalCallbackScope::InternalCallbackScope(Environment* env, CHECK(!object.IsEmpty()); } - HandleScope handle_scope(env->isolate()); // If you hit this assertion, you forgot to enter the v8::Context first. CHECK_EQ(Environment::GetCurrent(env->isolate()), env); @@ -956,7 +955,6 @@ InternalCallbackScope::~InternalCallbackScope() { void InternalCallbackScope::Close() { if (closed_) return; closed_ = true; - HandleScope handle_scope(env_->isolate()); if (pushed_ids_) env_->async_hooks()->pop_async_id(async_context_.async_id);