From 45bc39c1eb579aa8f99c3976a3f809e66e355cf7 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sun, 30 Sep 2018 12:08:30 -0400 Subject: [PATCH] src: deprecate `UVException()` without `Isolate*` This method, like all other methods which use `Isolate::GetCurrent()`, should be avoided. This was probably overlooked in 75adde07f9a2de7f38a. --- src/node.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/node.h b/src/node.h index d9b070d14ad469..64805cfac072dc 100644 --- a/src/node.h +++ b/src/node.h @@ -139,7 +139,8 @@ NODE_DEPRECATED("Use ErrnoException(isolate, ...)", path); }) -inline v8::Local UVException(int errorno, +NODE_DEPRECATED("Use UVException(isolate, ...)", + inline v8::Local UVException(int errorno, const char* syscall = nullptr, const char* message = nullptr, const char* path = nullptr) { @@ -148,7 +149,7 @@ inline v8::Local UVException(int errorno, syscall, message, path); -} +}) /* * These methods need to be called in a HandleScope.