From 38c1e05845a2b82924b970a974e23bf4dd57e5b9 Mon Sep 17 00:00:00 2001 From: Sam Roberts Date: Mon, 15 Oct 2018 15:37:19 -0700 Subject: [PATCH] test: check version strings have expected pattern Many were checked, but a few were not. --- test/parallel/test-process-versions.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/test/parallel/test-process-versions.js b/test/parallel/test-process-versions.js index 9a211286770586..a8f57ab0af17ab 100644 --- a/test/parallel/test-process-versions.js +++ b/test/parallel/test-process-versions.js @@ -34,9 +34,26 @@ assert(/^\d+\.\d+\.\d+(?:\.\d+)?-node\.\d+(?: \(candidate\))?$/ assert(/^\d+$/.test(process.versions.modules)); if (common.hasCrypto) { + // example: 1.1.0i assert(/^\d+\.\d+\.\d+[a-z]?$/.test(process.versions.openssl)); } +// example: 3 +assert(/^\d+$/.test(process.versions.napi)); +// example: 1.34.0 +assert(/^\d+\.\d+\.\d+$/.test(process.versions.nghttp2)); + +if (common.hasIntl) { + // example: 2018e + assert(/^\d{4}[a-z]$/.test(process.versions.tz)); + // example: 33.1 + assert(/^\d+\.\d+$/.test(process.versions.cldr)); + // example: 62.1 + assert(/^\d+\.\d+$/.test(process.versions.icu)); + // example: 11.0 + assert(/^\d+\.\d+$/.test(process.versions.unicode)); +} + for (let i = 0; i < expected_keys.length; i++) { const key = expected_keys[i]; const descriptor = Object.getOwnPropertyDescriptor(process.versions, key);