From 610bdac3b05f380089073b5a7797b3539dd186c0 Mon Sep 17 00:00:00 2001 From: Jagannath Bhat Date: Tue, 30 Oct 2018 23:08:04 +0530 Subject: [PATCH 1/2] Proof reading --- COLLABORATOR_GUIDE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 7cfc6388c549b5..2b33cd3ff778b9 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -497,7 +497,7 @@ This should be done where a pull request: Assign the `tsc-review` label or @-mention the `@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][]. -Do not use the GitHub UI on the right hand side to assign to +Do not use the GitHub UI on the right-hand side to assign to `@nodejs/tsc` or request a review from `@nodejs/tsc`. The TSC should serve as the final arbiter where required. @@ -528,7 +528,7 @@ The TSC should serve as the final arbiter where required. you are unsure exactly how to format the commit messages, use the commit log as a reference. See [this commit][commit-example] as an example. -For PRs from first time contributors, be [welcoming](#welcoming-first-time-contributors). +For PRs from first-time contributors, be [welcoming](#welcoming-first-time-contributors). Also, verify that their git settings are to their liking. All commits should be self-contained, meaning every commit should pass all @@ -548,7 +548,7 @@ $ npm install -g node-core-utils $ git node land $PRID ``` -If it's the first time you have used `node-core-utils`, you will be prompted +If it's the first-time you have used `node-core-utils`, you will be prompted to type the password of your GitHub account and the two-factor authentication code in the console so the tool can create the GitHub access token for you. If you do not want to do that, follow From ed7d85526332034dd93484d643bfe1ae186320bd Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 30 Oct 2018 23:27:01 -0700 Subject: [PATCH 2/2] fixup! nit --- COLLABORATOR_GUIDE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 2b33cd3ff778b9..fd26ea5f15d0db 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -548,7 +548,7 @@ $ npm install -g node-core-utils $ git node land $PRID ``` -If it's the first-time you have used `node-core-utils`, you will be prompted +If it's the first time you have used `node-core-utils`, you will be prompted to type the password of your GitHub account and the two-factor authentication code in the console so the tool can create the GitHub access token for you. If you do not want to do that, follow