From e8e1ea08e5ab80a4b5347d46993e22a4ab67a49c Mon Sep 17 00:00:00 2001 From: apoorvanand Date: Sat, 17 Nov 2018 18:09:30 +0530 Subject: [PATCH 1/3] test: fixed the arguments order in `assert.strictEqual` --- test/parallel/test-buffer-alloc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-buffer-alloc.js b/test/parallel/test-buffer-alloc.js index 313a13cb1e41ad..bdba19ae66ddb5 100644 --- a/test/parallel/test-buffer-alloc.js +++ b/test/parallel/test-buffer-alloc.js @@ -312,7 +312,7 @@ assert.strictEqual((Buffer.from('Man')).toString('base64'), 'TWFu'); 'dWVkIGFuZCBpbmRlZmF0aWdhYmxlIGdlbmVyYXRpb24gb2Yga25vd2xlZ' + 'GdlLCBleGNlZWRzIHRoZSBzaG9ydCB2ZWhlbWVuY2Ugb2YgYW55IGNhcm' + '5hbCBwbGVhc3VyZS4='; - assert.strictEqual(expected, (Buffer.from(quote)).toString('base64')); + assert.strictEqual((Buffer.from(quote)).toString('base64'), expected); let b = Buffer.allocUnsafe(1024); let bytesWritten = b.write(expected, 0, 'base64'); From d705e13fb1e21a0dcc1b1dd5ebb58944533575af Mon Sep 17 00:00:00 2001 From: apoorvanand Date: Sat, 17 Nov 2018 18:28:07 +0530 Subject: [PATCH 2/3] test: replace anonymous closure functions --- test/parallel/test-stream-pipe-await-drain.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-stream-pipe-await-drain.js b/test/parallel/test-stream-pipe-await-drain.js index 53cf54940d34e1..23b1e833b7239a 100644 --- a/test/parallel/test-stream-pipe-await-drain.js +++ b/test/parallel/test-stream-pipe-await-drain.js @@ -17,19 +17,19 @@ const buffer = Buffer.allocUnsafe(560000); reader._read = () => {}; -writer1._write = common.mustCall(function(chunk, encoding, cb) { +writer1._write = common.mustCall((chunk, encoding, cb) => { this.emit('chunk-received'); cb(); }, 1); -writer1.once('chunk-received', function() { +writer1.once('chunk-received', () => { assert.strictEqual( reader._readableState.awaitDrain, 0, 'awaitDrain initial value should be 0, actual is ' + reader._readableState.awaitDrain ); - setImmediate(function() { + setImmediate(() => { // This one should *not* get through to writer1 because writer2 is not // "done" processing. reader.push(buffer); @@ -37,7 +37,7 @@ writer1.once('chunk-received', function() { }); // A "slow" consumer: -writer2._write = common.mustCall(function(chunk, encoding, cb) { +writer2._write = common.mustCall((chunk, encoding, cb) => { assert.strictEqual( reader._readableState.awaitDrain, 1, @@ -49,7 +49,7 @@ writer2._write = common.mustCall(function(chunk, encoding, cb) { // will return false. }, 1); -writer3._write = common.mustCall(function(chunk, encoding, cb) { +writer3._write = common.mustCall((chunk, encoding, cb) => { assert.strictEqual( reader._readableState.awaitDrain, 2, From 4041623caaa5cc8f804c7669370ebf5662589f02 Mon Sep 17 00:00:00 2001 From: apoorvanand Date: Fri, 23 Nov 2018 00:37:40 +0530 Subject: [PATCH 3/3] Update test-stream-pipe-await-drain.js Changed back to non arrow function to fix it --- test/parallel/test-stream-pipe-await-drain.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-stream-pipe-await-drain.js b/test/parallel/test-stream-pipe-await-drain.js index 23b1e833b7239a..9286ceb791ce5f 100644 --- a/test/parallel/test-stream-pipe-await-drain.js +++ b/test/parallel/test-stream-pipe-await-drain.js @@ -17,7 +17,7 @@ const buffer = Buffer.allocUnsafe(560000); reader._read = () => {}; -writer1._write = common.mustCall((chunk, encoding, cb) => { +writer1._write = common.mustCall(function(chunk, encoding, cb) { this.emit('chunk-received'); cb(); }, 1);