From 39664bc925494c0082fa1029b8b3072405722b3c Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Thu, 7 Mar 2019 11:02:47 +0100 Subject: [PATCH] process: make Symbol.toStringTag writable The ecosystem broke by making it non-writable, so this is a good intermediate fix. --- lib/internal/bootstrap/node.js | 2 +- test/es-module/test-esm-process.mjs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js index aa6c6b262a4c2d..88ac437ac2bbaa 100644 --- a/lib/internal/bootstrap/node.js +++ b/lib/internal/bootstrap/node.js @@ -310,7 +310,7 @@ function setupProcessObject() { EventEmitter.call(process); Object.defineProperty(process, Symbol.toStringTag, { enumerable: false, - writable: false, + writable: true, configurable: false, value: 'process' }); diff --git a/test/es-module/test-esm-process.mjs b/test/es-module/test-esm-process.mjs index 24cf489a988565..ea9b4b4936a313 100644 --- a/test/es-module/test-esm-process.mjs +++ b/test/es-module/test-esm-process.mjs @@ -4,3 +4,4 @@ import assert from 'assert'; import process from 'process'; assert.strictEqual(Object.prototype.toString.call(process), '[object process]'); +assert(Object.getOwnPropertyDescriptor(process, Symbol.toStringTag).writable);