From 1fef02b4b5a7b5a6427b7b4fd76aa77ab6ee294c Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Thu, 4 Jul 2019 15:28:22 -0700 Subject: [PATCH] src: add missing option parser template for the DebugOptionsParser This allows embedders to run `node::options_parser::Parse` for a `node::DebugOptions`. --- src/node_options.cc | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/node_options.cc b/src/node_options.cc index 2b177806683a63..a7b9336de8ca93 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -231,6 +231,17 @@ class PerProcessOptionsParser : public OptionsParser { #if HAVE_INSPECTOR const DebugOptionsParser _dop_instance{}; const EnvironmentOptionsParser _eop_instance{_dop_instance}; + +// This Parse is not dead code, it used by embedders (Electron). +template <> +void Parse( + StringVector* const args, StringVector* const exec_args, + StringVector* const v8_args, + DebugOptions* const options, + OptionEnvvarSettings required_env_settings, StringVector* const errors) { + _dop_instance.Parse( + args, exec_args, v8_args, options, required_env_settings, errors); +} #else const EnvironmentOptionsParser _eop_instance{}; #endif // HAVE_INSPECTOR