From b6933441ec995a31cc988520dfc1dbc9821ac1a2 Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sat, 28 Sep 2019 09:39:14 +0200
Subject: [PATCH 1/8] doc: error modes of writable

---
 doc/api/stream.md | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index bf7ee7251af392..ac76a001b3e18d 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -432,6 +432,18 @@ file.end('world!');
 // Writing more now is not allowed!
 ```
 
+[`stream.end()`][stream-end] will error with (in order of precedence):
+* `ERR_STREAM_WRITE_AFTER_END` if `chunk` is not nully and
+[`stream.end()`][stream-end] has been called.
+* `ERR_STREAM_DESTROYED` if `chunk` is not nully and
+[`stream.destroy()`][stream-destroy] has been called.
+* `ERR_INVALID_ARG_TYPE` if `chunk` is not nully and
+`chunk` is not a `string` when not in `objectMode`.
+* `ERR_STREAM_ALREADY_FINISHED` if
+[`writable.writableFinished`][].
+* Any error emitted by the instance through `'error'` before
+[`writable.writableFinished`][].
+
 ##### writable.setDefaultEncoding(encoding)
 <!-- YAML
 added: v0.11.15
@@ -619,6 +631,13 @@ write('hello', () => {
 
 A `Writable` stream in object mode will always ignore the `encoding` argument.
 
+`stream.write()` will error with (in order of precedence):
+* `ERR_STREAM_WRITE_AFTER_END` if [`stream.end()`][stream-end] has been called.
+* `ERR_STREAM_DESTROYED` if [`stream.destroy()`][stream-destroy] has been called.
+* `ERR_STREAM_NULL_VALUES` if `chunk` is `null`.
+* `ERR_INVALID_ARG_TYPE` if `chunk` is not a `string` when not in `objectMode`.
+* Any error forwarded by `writable._write()`.
+
 ### Readable Streams
 
 Readable streams are an abstraction for a *source* from which data is

From 43e08449f3c3b5264ea96c40570880dd3701c8e9 Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Mon, 30 Sep 2019 19:16:38 +0200
Subject: [PATCH 2/8] Apply suggestions from code review

Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
---
 doc/api/stream.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index ac76a001b3e18d..3801d6a64cac48 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -436,13 +436,13 @@ file.end('world!');
 * `ERR_STREAM_WRITE_AFTER_END` if `chunk` is not nully and
 [`stream.end()`][stream-end] has been called.
 * `ERR_STREAM_DESTROYED` if `chunk` is not nully and
-[`stream.destroy()`][stream-destroy] has been called.
+[`stream.destroy()`][writable-destroy] has been called.
 * `ERR_INVALID_ARG_TYPE` if `chunk` is not nully and
 `chunk` is not a `string` when not in `objectMode`.
 * `ERR_STREAM_ALREADY_FINISHED` if
-[`writable.writableFinished`][].
+[`writable.writableFinished`][] is `true`.
 * Any error emitted by the instance through `'error'` before
-[`writable.writableFinished`][].
+[`writable.writableFinished`][] is set to `true`.
 
 ##### writable.setDefaultEncoding(encoding)
 <!-- YAML
@@ -633,7 +633,7 @@ A `Writable` stream in object mode will always ignore the `encoding` argument.
 
 `stream.write()` will error with (in order of precedence):
 * `ERR_STREAM_WRITE_AFTER_END` if [`stream.end()`][stream-end] has been called.
-* `ERR_STREAM_DESTROYED` if [`stream.destroy()`][stream-destroy] has been called.
+* `ERR_STREAM_DESTROYED` if [`stream.destroy()`][writable-destroy] has been called.
 * `ERR_STREAM_NULL_VALUES` if `chunk` is `null`.
 * `ERR_INVALID_ARG_TYPE` if `chunk` is not a `string` when not in `objectMode`.
 * Any error forwarded by `writable._write()`.

From 459ee59f597cfcc94fc5c55e3ce9c86214b7dd02 Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Fri, 4 Oct 2019 08:32:20 +0200
Subject: [PATCH 3/8] Update doc/api/stream.md

Co-Authored-By: Rich Trott <rtrott@gmail.com>
---
 doc/api/stream.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index 3801d6a64cac48..b31b8d0c5787f1 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -633,7 +633,8 @@ A `Writable` stream in object mode will always ignore the `encoding` argument.
 
 `stream.write()` will error with (in order of precedence):
 * `ERR_STREAM_WRITE_AFTER_END` if [`stream.end()`][stream-end] has been called.
-* `ERR_STREAM_DESTROYED` if [`stream.destroy()`][writable-destroy] has been called.
+* `ERR_STREAM_DESTROYED` if [`stream.destroy()`][writable-destroy] has been
+  called.
 * `ERR_STREAM_NULL_VALUES` if `chunk` is `null`.
 * `ERR_INVALID_ARG_TYPE` if `chunk` is not a `string` when not in `objectMode`.
 * Any error forwarded by `writable._write()`.

From 1bae447bd6ac9091aa627fe76d6571d45af01e2d Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sun, 24 Nov 2019 19:11:42 +0100
Subject: [PATCH 4/8] fixup

---
 doc/api/stream.md | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index b31b8d0c5787f1..b589f70ecbec81 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -432,7 +432,8 @@ file.end('world!');
 // Writing more now is not allowed!
 ```
 
-[`stream.end()`][stream-end] will error with (in order of precedence):
+[`stream.end()`][stream-end] will call it's callback and emit `'error'`
+with (in order of precedence):
 * `ERR_STREAM_WRITE_AFTER_END` if `chunk` is not nully and
 [`stream.end()`][stream-end] has been called.
 * `ERR_STREAM_DESTROYED` if `chunk` is not nully and
@@ -631,7 +632,8 @@ write('hello', () => {
 
 A `Writable` stream in object mode will always ignore the `encoding` argument.
 
-`stream.write()` will error with (in order of precedence):
+`stream.write()`  will call it's callback and emit `'error'`
+with (in order of precedence):
 * `ERR_STREAM_WRITE_AFTER_END` if [`stream.end()`][stream-end] has been called.
 * `ERR_STREAM_DESTROYED` if [`stream.destroy()`][writable-destroy] has been
   called.

From 5f5e28277455b8a26eff508ad2e37f020bc94a72 Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sun, 24 Nov 2019 20:42:48 +0100
Subject: [PATCH 5/8] Update doc/api/stream.md

Co-Authored-By: Yorkie Liu <yorkiefixer@gmail.com>
---
 doc/api/stream.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index b589f70ecbec81..1bd822cae4c2ca 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -432,7 +432,7 @@ file.end('world!');
 // Writing more now is not allowed!
 ```
 
-[`stream.end()`][stream-end] will call it's callback and emit `'error'`
+[`stream.end()`][stream-end] will call its callback and emit `'error'`
 with (in order of precedence):
 * `ERR_STREAM_WRITE_AFTER_END` if `chunk` is not nully and
 [`stream.end()`][stream-end] has been called.

From e9ef9381b05e7559cb145d2b299e0c893a560176 Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sun, 24 Nov 2019 20:48:00 +0100
Subject: [PATCH 6/8] fixup: formatting

---
 doc/api/stream.md | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index 1bd822cae4c2ca..c325acd1ba62fe 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -435,15 +435,15 @@ file.end('world!');
 [`stream.end()`][stream-end] will call its callback and emit `'error'`
 with (in order of precedence):
 * `ERR_STREAM_WRITE_AFTER_END` if `chunk` is not nully and
-[`stream.end()`][stream-end] has been called.
+ [`stream.end()`][stream-end] has been called.
 * `ERR_STREAM_DESTROYED` if `chunk` is not nully and
-[`stream.destroy()`][writable-destroy] has been called.
+ [`stream.destroy()`][writable-destroy] has been called.
 * `ERR_INVALID_ARG_TYPE` if `chunk` is not nully and
-`chunk` is not a `string` when not in `objectMode`.
+ `chunk` is not a `string` when not in `objectMode`.
 * `ERR_STREAM_ALREADY_FINISHED` if
-[`writable.writableFinished`][] is `true`.
+ [`writable.writableFinished`][] is `true`.
 * Any error emitted by the instance through `'error'` before
-[`writable.writableFinished`][] is set to `true`.
+ [`writable.writableFinished`][] is set to `true`.
 
 ##### writable.setDefaultEncoding(encoding)
 <!-- YAML
@@ -632,7 +632,7 @@ write('hello', () => {
 
 A `Writable` stream in object mode will always ignore the `encoding` argument.
 
-`stream.write()`  will call it's callback and emit `'error'`
+[`stream.write()`][stream-write] will call its callback and emit `'error'`
 with (in order of precedence):
 * `ERR_STREAM_WRITE_AFTER_END` if [`stream.end()`][stream-end] has been called.
 * `ERR_STREAM_DESTROYED` if [`stream.destroy()`][writable-destroy] has been

From bdfb2d46e1a6bb7ac2c8fe1f440cf80e3f2ac65c Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sun, 24 Nov 2019 20:56:05 +0100
Subject: [PATCH 7/8] Update doc/api/stream.md

Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
---
 doc/api/stream.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index c325acd1ba62fe..e682a016b94cab 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -442,7 +442,7 @@ with (in order of precedence):
  `chunk` is not a `string` when not in `objectMode`.
 * `ERR_STREAM_ALREADY_FINISHED` if
  [`writable.writableFinished`][] is `true`.
-* Any error emitted by the instance through `'error'` before
+* Last error emitted by the instance through `'error'` before
  [`writable.writableFinished`][] is set to `true`.
 
 ##### writable.setDefaultEncoding(encoding)

From 6f797e4ccbdb4bc77b40389c18d2f3bdca0b2b7e Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sun, 1 Dec 2019 20:11:05 +0100
Subject: [PATCH 8/8] Update doc/api/stream.md

Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
---
 doc/api/stream.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index e682a016b94cab..d1b77c30fe5524 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -639,7 +639,7 @@ with (in order of precedence):
   called.
 * `ERR_STREAM_NULL_VALUES` if `chunk` is `null`.
 * `ERR_INVALID_ARG_TYPE` if `chunk` is not a `string` when not in `objectMode`.
-* Any error forwarded by `writable._write()`.
+* Any error forwarded from `writable._write()` or `writable._writev()`.
 
 ### Readable Streams