From be9c0e6b4a8d4740c2fbae90109ce8e319bdb9b9 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Fri, 29 Nov 2019 16:52:50 -0500 Subject: [PATCH 1/4] doc: update status of Python 3 support Refs: https://github.com/nodejs/TSC/pull/781#issuecomment-559666380 Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. --- BUILDING.md | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index a65198b7a86cfc..ee4491112d0081 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -223,18 +223,17 @@ Consult previous versions of this document for older versions of Node.js: ### Note about Python 2 and Python 3 -The Node.js project uses Python as part of its build process and has +The Node.js project uses Python as part of its build process and was historically only been Python 2 compatible. Python 2 will reach its _end-of-life_ at the end of 2019 at which point the interpreter will cease receiving updates. See https://python3statement.org/ for more information. -The Node.js project is in the process of transitioning its Python code to -Python 3 compatibility. Installing both versions of Python while building -and testing Node.js allows developers and end users to test, benchmark, -and debug Node.js running on both versions to ensure a smooth and complete -transition before the year-end deadline. +The Node.js project now supports both Python 3 and Python 2 for building. +If both are installed Python 3 will be used. If only Python 2 is available +it will be used instead. When possible we recommend that you build and +test with Python 3. ### Unix and macOS @@ -244,7 +243,7 @@ transition before the year-end deadline. * GNU Make 3.81 or newer * Python (see note above) * Python 2.7 - * Python 3.5, 3.6, 3.7, and 3.8 are experimental. + * Python 3.5, 3.6, 3.7, and 3.8. Installation via Linux package manager can be achieved with: @@ -260,7 +259,7 @@ FreeBSD and OpenBSD users may also need to install `libexecinfo`. * Xcode Command Line Tools >= 10 for macOS * Python (see note above) * Python 2.7 - * Python 3.5, 3.6, 3.7, and 3.8 are experimental. + * Python 3.5, 3.6, 3.7, and 3.8. macOS users can install the `Xcode Command Line Tools` by running `xcode-select --install`. Alternatively, if you already have the full Xcode From 57d510e623a842153554c458be627e9469708d19 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 3 Dec 2019 10:37:36 -0500 Subject: [PATCH 2/4] Update BUILDING.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Michaël Zasso --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index ee4491112d0081..a0784921f3c464 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -224,7 +224,7 @@ Consult previous versions of this document for older versions of Node.js: ### Note about Python 2 and Python 3 The Node.js project uses Python as part of its build process and was -historically only been Python 2 compatible. +historically only Python 2 compatible. Python 2 will reach its _end-of-life_ at the end of 2019 at which point the interpreter will cease receiving updates. See https://python3statement.org/ From cc4d4f8ca9af913c6897a23dfdbd5a59887e3ec4 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 3 Dec 2019 10:38:14 -0500 Subject: [PATCH 3/4] Update BUILDING.md --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index a0784921f3c464..abe0d60d6220a5 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -230,7 +230,7 @@ Python 2 will reach its _end-of-life_ at the end of 2019 at which point the interpreter will cease receiving updates. See https://python3statement.org/ for more information. -The Node.js project now supports both Python 3 and Python 2 for building. +The Node.js project supports both Python 3 and Python 2 for building. If both are installed Python 3 will be used. If only Python 2 is available it will be used instead. When possible we recommend that you build and test with Python 3. From 2d388e55e4827795810dd71d32c8e8ff79f75f4a Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 3 Dec 2019 10:41:21 -0500 Subject: [PATCH 4/4] squash: address comments --- BUILDING.md | 7 ------- 1 file changed, 7 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index abe0d60d6220a5..0b707fe1e09e2a 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -223,13 +223,6 @@ Consult previous versions of this document for older versions of Node.js: ### Note about Python 2 and Python 3 -The Node.js project uses Python as part of its build process and was -historically only Python 2 compatible. - -Python 2 will reach its _end-of-life_ at the end of 2019 at which point the -interpreter will cease receiving updates. See https://python3statement.org/ -for more information. - The Node.js project supports both Python 3 and Python 2 for building. If both are installed Python 3 will be used. If only Python 2 is available it will be used instead. When possible we recommend that you build and