From daf2adda33afa3569bc24778b050a9942c3686a3 Mon Sep 17 00:00:00 2001
From: Matheus Marchini <mmarchini@netflix.com>
Date: Wed, 18 Mar 2020 16:53:05 -0700
Subject: [PATCH] build: rework ASAN build on Actions

Changed from Debug build to Release build to avoid out of memory issues
during the link step. This should also speed up the build.

Commented out the test runner for now, since there are too many ASAN
warnings there to be useful. We should re-enable the test runner once
our ASAN warnings are fixed.

Simplify the environment: instead of running on a container, runs
directly on the host. With this, ASAN build looks identical to other
builds in GitHub Actions, with the exception of the `--enable-asan`
flag.

Ref: https://github.com/nodejs/node/issue/32257
Ref: https://github.com/nodejs/node/pull/32324
---
 .github/workflows/ASAN.yml | 36 ++++++++++++++++--------------------
 1 file changed, 16 insertions(+), 20 deletions(-)

diff --git a/.github/workflows/ASAN.yml b/.github/workflows/ASAN.yml
index 3c15c134ee5c2c..5defbead5b736d 100644
--- a/.github/workflows/ASAN.yml
+++ b/.github/workflows/ASAN.yml
@@ -3,23 +3,19 @@ name: node ASAN
 on: [push, pull_request]
 
 jobs:
-  ubuntu-build:
-      runs-on: ubuntu-latest
-      container: gengjiawen/node-build:2020-02-14
-      steps:
-        - uses: actions/checkout@v2
-        - name: Build
-          # TODO(mmarchini): With V8 8.1, GitHub Actions doesn't have enough
-          # memory to build with debug and ASAN. Allow this build to fail until
-          # we figure out a workaround, or until we update to 8.2 (where build
-          # is passing).
-          continue-on-error: true
-          run: |
-              npx envinfo
-              ./configure --debug --enable-asan --ninja && ninja -C out/Debug
-        - name: Test
-          env:
-            ASAN_OPTIONS: halt_on_error=0
-          continue-on-error: true
-          run: |
-            python3 tools/test.py -J --mode=debug
+  build-linux-asan:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build
+        run: ./configure --enable-asan && make -j2
+      # TODO(mmarchini): re-enable tests when we fix all issues pointed out
+      # by ASAN
+      # - name: Test
+      #   env:
+      #     ASAN_OPTIONS: halt_on_error=0
+      #   continue-on-error: true
+      #   run: |
+      #     python3 tools/test.py -J