From 81a4018c139424b725b510176bbca80d86f1432d Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 8 Apr 2020 11:32:49 -0400 Subject: [PATCH 1/2] doc: updated guidance for n-api changes Add js_native_api.h and js_native_api_types.h to the list of files covered by the N-API guidance as these were broken out of the files referenced. Signed-off-by: Michael Dawson --- doc/guides/collaborator-guide.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/collaborator-guide.md b/doc/guides/collaborator-guide.md index 5a105b6cee8137..09ee1832aa8bfd 100644 --- a/doc/guides/collaborator-guide.md +++ b/doc/guides/collaborator-guide.md @@ -332,8 +332,8 @@ For pull requests introducing new core modules: ### Additions to N-API N-API provides an ABI-stable API guaranteed for future Node.js versions. N-API -additions call for unusual care and scrutiny. If a change adds to `node_api.h` -or `node_api_types.h`, consult [the relevant +additions call for unusual care and scrutiny. If a change adds to `node_api.h`, +`js_native_api.h`, `node_api_types.h` or `js_native_api_types.h`, consult [the relevant guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md). ### Deprecations From c954874654beec20c10087cbb43ef03107ed0708 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 13 Apr 2020 17:15:56 -0400 Subject: [PATCH 2/2] Update doc/guides/collaborator-guide.md Co-Authored-By: Rich Trott --- doc/guides/collaborator-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/collaborator-guide.md b/doc/guides/collaborator-guide.md index 09ee1832aa8bfd..c08834ea4a1352 100644 --- a/doc/guides/collaborator-guide.md +++ b/doc/guides/collaborator-guide.md @@ -333,7 +333,7 @@ For pull requests introducing new core modules: N-API provides an ABI-stable API guaranteed for future Node.js versions. N-API additions call for unusual care and scrutiny. If a change adds to `node_api.h`, -`js_native_api.h`, `node_api_types.h` or `js_native_api_types.h`, consult [the relevant +`js_native_api.h`, `node_api_types.h`, or `js_native_api_types.h`, consult [the relevant guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md). ### Deprecations