From b41995fda5445f790af05916146f624f2e2d3177 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 31 Jul 2020 11:57:53 -0400 Subject: [PATCH 1/2] tools: fix checkimports.py when passed arguments Fix checkimports.py so that all passed arguments are checked instead of just the first one. --- tools/checkimports.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/checkimports.py b/tools/checkimports.py index 609a75f542748f..7a2a22248403de 100755 --- a/tools/checkimports.py +++ b/tools/checkimports.py @@ -41,5 +41,5 @@ def is_valid(file_name): return valid if __name__ == '__main__': - files = glob.iglob(sys.argv[1] if len(sys.argv) > 1 else 'src/*.cc') + files = sys.argv[1:] if len(sys.argv) > 1 else glob.iglob('src/*.cc') sys.exit(0 if all(map(is_valid, files)) else 1) From e7222d1dc047824cd0f8478d936fcad4aacfba4c Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 31 Jul 2020 12:08:46 -0400 Subject: [PATCH 2/2] temporary debug --- tools/checkimports.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/checkimports.py b/tools/checkimports.py index 7a2a22248403de..a99acc5a453e7d 100755 --- a/tools/checkimports.py +++ b/tools/checkimports.py @@ -42,4 +42,5 @@ def is_valid(file_name): if __name__ == '__main__': files = sys.argv[1:] if len(sys.argv) > 1 else glob.iglob('src/*.cc') + print(list(files)) sys.exit(0 if all(map(is_valid, files)) else 1)