From 0069f73ac816bfcd25e54cd1333371c82cc85630 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Tue, 26 Jan 2021 22:42:13 -0500 Subject: [PATCH] readline: replace _questionCancel with a symbol This commit avoids exposing a new underscored property on readline Interface instances. --- lib/readline.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/readline.js b/lib/readline.js index a284cc8afcf0d0..13ec53e0386cbd 100644 --- a/lib/readline.js +++ b/lib/readline.js @@ -116,6 +116,7 @@ const kMincrlfDelay = 100; const lineEnding = /\r?\n|\r(?!\n)/; const kLineObjectStream = Symbol('line object stream'); +const kQuestionCancel = Symbol('kQuestionCancel'); const KEYPRESS_DECODER = Symbol('keypress-decoder'); const ESCAPE_DECODER = Symbol('escape-decoder'); @@ -224,7 +225,7 @@ function Interface(input, output, completer, terminal) { }; } - this._questionCancel = FunctionPrototypeBind(_questionCancel, this); + this[kQuestionCancel] = FunctionPrototypeBind(_questionCancel, this); this.setPrompt(prompt); @@ -375,7 +376,7 @@ Interface.prototype.question = function(query, options, cb) { if (options.signal) { options.signal.addEventListener('abort', () => { - this._questionCancel(); + this[kQuestionCancel](); }, { once: true }); }