From ffe11badbc6e17276510c16e58dfde5767b7daf3 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 2 Jun 2021 19:40:44 +0200 Subject: [PATCH 1/4] doc: deprecate using non-boolean values in the `verbatim` option --- doc/api/deprecations.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index b9e1d90f0006a2..15f14e85674ffc 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2786,6 +2786,19 @@ These properties are now available within the standard `detail` property of the `PerformanceEntry` object. The existing accessors have been deprecated and should no longer be used. +### DEP0153: Non boolean value for `verbatim` DNS lookup option + + +Type: Documentation-only + +Using a non-boolean value for `verbatim` option in [`dns.lookup()`][] and +[`dnsPromises.lookup()`][] is deprecated. + [Legacy URL API]: url.md#url_legacy_url_api [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3 @@ -2825,6 +2838,8 @@ deprecated and should no longer be used. [`crypto.scrypt()`]: crypto.md#crypto_crypto_scrypt_password_salt_keylen_options_callback [`decipher.final()`]: crypto.md#crypto_decipher_final_outputencoding [`decipher.setAuthTag()`]: crypto.md#crypto_decipher_setauthtag_buffer_encoding +[`dns.lookup()`]: domain.md#dns_dns_lookup_hostname_options_callback +[`dnsPromises.lookup()`]: domain.md#dns_dnspromises_lookup_hostname_options [`domain`]: domain.md [`ecdh.setPublicKey()`]: crypto.md#crypto_ecdh_setpublickey_publickey_encoding [`emitter.listenerCount(eventName)`]: events.md#events_emitter_listenercount_eventname From 9bb3a8401f4f013064d4221b5fe8626f27fe4386 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 11 Jun 2021 16:20:27 +0200 Subject: [PATCH 2/4] fixup! doc: deprecate using non-boolean values in the `verbatim` option --- doc/api/deprecations.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 15f14e85674ffc..a6944ffd9135da 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2790,7 +2790,7 @@ deprecated and should no longer be used. From 713319c3ba4f565fe02040ff90b921f9a99be3da Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 11 Jun 2021 16:26:17 +0200 Subject: [PATCH 3/4] doc: deprecate type coercion for `dns.lookup` options --- doc/api/deprecations.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index a6944ffd9135da..f8e7c2a46c3fdd 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2786,7 +2786,7 @@ These properties are now available within the standard `detail` property of the `PerformanceEntry` object. The existing accessors have been deprecated and should no longer be used. -### DEP0153: Non boolean value for `verbatim` DNS lookup option +### DEP0153: `dns.lookup` and `dnsPromises.lookup` options type coercion