From 1d2dc6452a2fb7141c921ff16e1bd6993e150565 Mon Sep 17 00:00:00 2001 From: Voltrex Date: Thu, 10 Jun 2021 02:17:12 +0430 Subject: [PATCH 1/2] net: use missing validator The `net` lib module's `lookupAndConnect()` function is missing a validator. --- lib/net.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/net.js b/lib/net.js index 4b55366f87dae0..d00947521cace3 100644 --- a/lib/net.js +++ b/lib/net.js @@ -102,6 +102,7 @@ const { const { isUint8Array } = require('internal/util/types'); const { validateAbortSignal, + validateFunction, validateInt32, validateNumber, validatePort, @@ -1002,10 +1003,7 @@ function lookupAndConnect(self, options) { return; } - if (options.lookup && typeof options.lookup !== 'function') - throw new ERR_INVALID_ARG_TYPE('options.lookup', - 'Function', options.lookup); - + if (options.lookup) validateFunction(options.lookup, 'options.lookup'); if (dns === undefined) dns = require('dns'); const dnsopts = { From 52269ec6b15a56d5f835d5f8314a00bd369e8070 Mon Sep 17 00:00:00 2001 From: Voltrex Date: Fri, 11 Jun 2021 21:38:03 +0430 Subject: [PATCH 2/2] fixup! net: use missing validator Check if the value of `options.lookup` doesn't equal to `undefined`. Co-authored-by: James M Snell --- lib/net.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/net.js b/lib/net.js index d00947521cace3..899e73f6ff167d 100644 --- a/lib/net.js +++ b/lib/net.js @@ -1003,7 +1003,8 @@ function lookupAndConnect(self, options) { return; } - if (options.lookup) validateFunction(options.lookup, 'options.lookup'); + if (options.lookup !== undefined) + validateFunction(options.lookup, 'options.lookup'); if (dns === undefined) dns = require('dns'); const dnsopts = {