From a1d1f90bc5cd8ee12924a0c0fd7e54b25db0b5ef Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Tue, 14 Jun 2022 08:57:14 +0200 Subject: [PATCH 1/2] test: make node-api/test_buffer/test_finalizer not flaky --- test/node-api/test_buffer/test_finalizer.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/node-api/test_buffer/test_finalizer.js b/test/node-api/test_buffer/test_finalizer.js index e9bdd53c6dff8e..372116bb3a05fc 100644 --- a/test/node-api/test_buffer/test_finalizer.js +++ b/test/node-api/test_buffer/test_finalizer.js @@ -16,6 +16,10 @@ process.on('uncaughtException', common.mustCall((err) => { throw new Error('finalizer error'); })); } + global.gc(true); + await tick(common.platformTimeout(100)); global.gc(); - await tick(10); + await tick(common.platformTimeout(100)); + global.gc(); + await tick(common.platformTimeout(100)); })().then(common.mustCall()); From 49d643652d4e4eb1eee61d53ffe62de6965128c9 Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Thu, 16 Jun 2022 00:32:47 +0200 Subject: [PATCH 2/2] Revert "test: mark test_buffer/test_finalizer flaky" This reverts commit 73d8db896ee9d016f6832295e242e79cfe464be8. --- test/node-api/node-api.status | 1 - 1 file changed, 1 deletion(-) diff --git a/test/node-api/node-api.status b/test/node-api/node-api.status index be3a2761c414fc..9395bfe1f6bbe0 100644 --- a/test/node-api/node-api.status +++ b/test/node-api/node-api.status @@ -5,6 +5,5 @@ prefix node-api # sample-test : PASS,FLAKY [true] # This section applies to all platforms -test_buffer/test_finalizer : PASS,FLAKY [$system==win32]