From 27e92a0fa75ee39a997d2289af9e5ede060027cf Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 19 Nov 2022 07:45:40 -0800 Subject: [PATCH 1/2] test: revise pull request guide text about code Fixes: https://github.com/nodejs/node/issues/45502 --- doc/contributing/pull-requests.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index cf130d0d2e5391..208af0f39138fe 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -107,13 +107,13 @@ git checkout -b my-branch -t upstream/HEAD ### Step 3: Code -The vast majority of pull requests opened against the `nodejs/node` -repository includes changes to one or more of the following: +Pull requests in Node.js typically involve changes to +one or more of a few places in the code base. -* the C/C++ code contained in the `src` directory -* the JavaScript code contained in the `lib` directory -* the documentation in `doc/api` -* tests within the `test` directory. +* C/C++ code contained in the `src` directory +* JavaScript code contained in the `lib` directory +* Documentation in `doc/api` +* Tests within the `test` directory If you are modifying code, please be sure to run `make lint` (or `vcbuild.bat lint` on Windows) to ensure that the changes follow the Node.js From 5374a5c119468290de292614040202fb65f9569b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 19 Nov 2022 07:47:16 -0800 Subject: [PATCH 2/2] fixup! test: revise pull request guide text about code --- doc/contributing/pull-requests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index 208af0f39138fe..33715bc3c2096e 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -108,7 +108,7 @@ git checkout -b my-branch -t upstream/HEAD ### Step 3: Code Pull requests in Node.js typically involve changes to -one or more of a few places in the code base. +one or more of a few places in the repository. * C/C++ code contained in the `src` directory * JavaScript code contained in the `lib` directory