From 2c146b68156056599b9499f5300b084a328300f5 Mon Sep 17 00:00:00 2001
From: Deokjin Kim <deokjin81.kim@gmail.com>
Date: Wed, 30 Nov 2022 01:33:06 +0900
Subject: [PATCH 1/2] doc,lib: fix mismatched arguments of `NodeEventTarget`

Arguments of some APIs are mismatched and 2 APIs are not
described.
---
 doc/api/events.md            | 46 ++++++++++++++++++++++++++----------
 lib/internal/event_target.js |  2 +-
 2 files changed, 34 insertions(+), 14 deletions(-)

diff --git a/doc/api/events.md b/doc/api/events.md
index ce36bb7dbcd05a..e411902e4dabdd 100644
--- a/doc/api/events.md
+++ b/doc/api/events.md
@@ -2027,7 +2027,7 @@ added: v14.5.0
 The `NodeEventTarget` is a Node.js-specific extension to `EventTarget`
 that emulates a subset of the `EventEmitter` API.
 
-#### `nodeEventTarget.addListener(type, listener[, options])`
+#### `nodeEventTarget.addListener(type, listener)`
 
 <!-- YAML
 added: v14.5.0
@@ -2037,9 +2037,6 @@ added: v14.5.0
 
 * `listener` {Function|EventListener}
 
-* `options` {Object}
-  * `once` {boolean}
-
 * Returns: {EventTarget} this
 
 Node.js-specific extension to the `EventTarget` class that emulates the
@@ -2071,7 +2068,29 @@ added: v14.5.0
 Node.js-specific extension to the `EventTarget` class that returns the number
 of event listeners registered for the `type`.
 
-#### `nodeEventTarget.off(type, listener)`
+#### `nodeEventTarget.setMaxListeners(n)`
+
+<!-- YAML
+added: v14.5.0
+-->
+
+* `n` {number}
+
+Node.js-specific extension to the `EventTarget` class that sets the number
+of max event listeners as `n`.
+
+#### `nodeEventTarget.getMaxListeners()`
+
+<!-- YAML
+added: v14.5.0
+-->
+
+* Returns: {number}
+
+Node.js-specific extension to the `EventTarget` class that returns the number
+of max event listeners.
+
+#### `nodeEventTarget.off(type, listener[, options])`
 
 <!-- YAML
 added: v14.5.0
@@ -2081,11 +2100,14 @@ added: v14.5.0
 
 * `listener` {Function|EventListener}
 
+* `options` {Object}
+  * `capture` {boolean}
+
 * Returns: {EventTarget} this
 
 Node.js-specific alias for `eventTarget.removeListener()`.
 
-#### `nodeEventTarget.on(type, listener[, options])`
+#### `nodeEventTarget.on(type, listener)`
 
 <!-- YAML
 added: v14.5.0
@@ -2095,14 +2117,11 @@ added: v14.5.0
 
 * `listener` {Function|EventListener}
 
-* `options` {Object}
-  * `once` {boolean}
-
 * Returns: {EventTarget} this
 
 Node.js-specific alias for `eventTarget.addListener()`.
 
-#### `nodeEventTarget.once(type, listener[, options])`
+#### `nodeEventTarget.once(type, listener)`
 
 <!-- YAML
 added: v14.5.0
@@ -2112,8 +2131,6 @@ added: v14.5.0
 
 * `listener` {Function|EventListener}
 
-* `options` {Object}
-
 * Returns: {EventTarget} this
 
 Node.js-specific extension to the `EventTarget` class that adds a `once`
@@ -2134,7 +2151,7 @@ Node.js-specific extension to the `EventTarget` class. If `type` is specified,
 removes all registered listeners for `type`, otherwise removes all registered
 listeners.
 
-#### `nodeEventTarget.removeListener(type, listener)`
+#### `nodeEventTarget.removeListener(type, listener[, options])`
 
 <!-- YAML
 added: v14.5.0
@@ -2144,6 +2161,9 @@ added: v14.5.0
 
 * `listener` {Function|EventListener}
 
+* `options` {Object}
+  * `capture` {boolean}
+
 * Returns: {EventTarget} this
 
 Node.js-specific extension to the `EventTarget` class that removes the
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
index c0347d79d6cd3e..6af4aef2fa1bc2 100644
--- a/lib/internal/event_target.js
+++ b/lib/internal/event_target.js
@@ -821,7 +821,7 @@ class NodeEventTarget extends EventTarget {
   }
 
   /**
-   * @param {string} [type]
+   * @param {string} type
    * @returns {number}
    */
   listenerCount(type) {

From 0b14500ab392f9588f271bfd913f032a9a84baec Mon Sep 17 00:00:00 2001
From: Deokjin Kim <deokjin81.kim@gmail.com>
Date: Mon, 5 Dec 2022 20:11:21 +0900
Subject: [PATCH 2/2] update list of unsupported function in `NodeEventTarget`

---
 doc/api/events.md | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/doc/api/events.md b/doc/api/events.md
index e411902e4dabdd..102dd6614c6895 100644
--- a/doc/api/events.md
+++ b/doc/api/events.md
@@ -1645,9 +1645,8 @@ and cannot be used in place of an `EventEmitter` in most cases.
    ignored.
 2. The `NodeEventTarget` does not emulate the full `EventEmitter` API.
    Specifically the `prependListener()`, `prependOnceListener()`,
-   `rawListeners()`, `setMaxListeners()`, `getMaxListeners()`, and
-   `errorMonitor` APIs are not emulated. The `'newListener'` and
-   `'removeListener'` events will also not be emitted.
+   `rawListeners()`, and `errorMonitor` APIs are not emulated.
+   The `'newListener'` and `'removeListener'` events will also not be emitted.
 3. The `NodeEventTarget` does not implement any special default behavior
    for events with type `'error'`.
 4. The `NodeEventTarget` supports `EventListener` objects as well as