diff --git a/lib/internal/histogram.js b/lib/internal/histogram.js index ca540e555e0160..23b8b8a7652dc4 100644 --- a/lib/internal/histogram.js +++ b/lib/internal/histogram.js @@ -3,7 +3,6 @@ const { MapPrototypeEntries, NumberIsNaN, - NumberIsInteger, NumberMAX_SAFE_INTEGER, ObjectFromEntries, ReflectConstruct, @@ -187,9 +186,8 @@ class Histogram { if (!isHistogram(this)) throw new ERR_INVALID_THIS('Histogram'); validateNumber(percentile, 'percentile'); - if (NumberIsNaN(percentile) || percentile <= 0 || percentile > 100) - throw new ERR_INVALID_ARG_VALUE.RangeError('percentile', percentile); + throw new ERR_OUT_OF_RANGE('percentile', '> 0 && <= 100', percentile); return this[kHandle]?.percentile(percentile); } @@ -202,9 +200,8 @@ class Histogram { if (!isHistogram(this)) throw new ERR_INVALID_THIS('Histogram'); validateNumber(percentile, 'percentile'); - if (NumberIsNaN(percentile) || percentile <= 0 || percentile > 100) - throw new ERR_INVALID_ARG_VALUE.RangeError('percentile', percentile); + throw new ERR_OUT_OF_RANGE('percentile', '> 0 && <= 100', percentile); return this[kHandle]?.percentileBigInt(percentile); } @@ -284,11 +281,7 @@ class RecordableHistogram extends Histogram { return; } - if (!NumberIsInteger(val)) - throw new ERR_INVALID_ARG_TYPE('val', ['integer', 'bigint'], val); - - if (val < 1 || val > NumberMAX_SAFE_INTEGER) - throw new ERR_OUT_OF_RANGE('val', 'a safe integer greater than 0', val); + validateInteger(val, 'val', 1); this[kHandle]?.record(val); } diff --git a/test/sequential/test-performance-eventloopdelay.js b/test/sequential/test-performance-eventloopdelay.js index f262e9de3fe6cb..24e5744118cc38 100644 --- a/test/sequential/test-performance-eventloopdelay.js +++ b/test/sequential/test-performance-eventloopdelay.js @@ -91,7 +91,7 @@ const { sleep } = require('internal/util'); () => histogram.percentile(i), { name: 'RangeError', - code: 'ERR_INVALID_ARG_VALUE' + code: 'ERR_OUT_OF_RANGE' } ); });