From bdce280e43d604310731bcb657c579055b0235cb Mon Sep 17 00:00:00 2001 From: Moshe Atlow Date: Wed, 21 Dec 2022 09:52:11 +0200 Subject: [PATCH 1/3] test: fix flakyness in test-runner reporter test --- test/parallel/test-runner-reporters.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-runner-reporters.js b/test/parallel/test-runner-reporters.js index 74cae3401e2843..9ffc3863e97e5a 100644 --- a/test/parallel/test-runner-reporters.js +++ b/test/parallel/test-runner-reporters.js @@ -89,7 +89,7 @@ describe('node:test reporters', { concurrency: true }, () => { ['--test', '--test-reporter', fixtures.path('test-runner/custom_reporters/', filename), testFile]); assert.strictEqual(child.stderr.toString(), ''); - assert.strictEqual(child.stdout.toString(), `${filename} {"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":7}`); + assert.match(child.stdout.toString(), new RegExp(`${filename} {"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":\\d}`)); }); }); }); From 01b98e67f1cd96dcd38c3b6016741738b57381d3 Mon Sep 17 00:00:00 2001 From: Moshe Atlow Date: Wed, 21 Dec 2022 13:50:45 +0200 Subject: [PATCH 2/3] Update test/parallel/test-runner-reporters.js Co-authored-by: Antoine du Hamel --- test/parallel/test-runner-reporters.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-runner-reporters.js b/test/parallel/test-runner-reporters.js index 9ffc3863e97e5a..0920602ad6113c 100644 --- a/test/parallel/test-runner-reporters.js +++ b/test/parallel/test-runner-reporters.js @@ -89,7 +89,9 @@ describe('node:test reporters', { concurrency: true }, () => { ['--test', '--test-reporter', fixtures.path('test-runner/custom_reporters/', filename), testFile]); assert.strictEqual(child.stderr.toString(), ''); - assert.match(child.stdout.toString(), new RegExp(`${filename} {"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":\\d}`)); + const stdout = child.stdout.toString(); + assert.match(stdout, /{"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":\d+}$/); + assert.strictEqual(stdout.slice(0, filename.length + 2), `${filename} {`); }); }); }); From 49c4df76839bd4e4d473e67f9ace570d9562b93f Mon Sep 17 00:00:00 2001 From: Moshe Atlow Date: Wed, 21 Dec 2022 17:37:30 +0200 Subject: [PATCH 3/3] lint --- test/parallel/test-runner-reporters.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-runner-reporters.js b/test/parallel/test-runner-reporters.js index 0920602ad6113c..b649fe529629f2 100644 --- a/test/parallel/test-runner-reporters.js +++ b/test/parallel/test-runner-reporters.js @@ -89,7 +89,7 @@ describe('node:test reporters', { concurrency: true }, () => { ['--test', '--test-reporter', fixtures.path('test-runner/custom_reporters/', filename), testFile]); assert.strictEqual(child.stderr.toString(), ''); - const stdout = child.stdout.toString(); + const stdout = child.stdout.toString(); assert.match(stdout, /{"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":\d+}$/); assert.strictEqual(stdout.slice(0, filename.length + 2), `${filename} {`); });