From 7910aa84fd38c28a3db43559726edc22cefd3159 Mon Sep 17 00:00:00 2001 From: Dario Presutti Date: Sat, 18 Nov 2023 16:57:02 +0100 Subject: [PATCH 1/5] test: replace forEach() test-stream-pipe-unpipe-stream.js test: fix lint error --- .../test-stream-pipe-unpipe-streams.js | 25 +++++++++---------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/test/parallel/test-stream-pipe-unpipe-streams.js b/test/parallel/test-stream-pipe-unpipe-streams.js index b1a673d9450ce8..dcf59e835d830e 100644 --- a/test/parallel/test-stream-pipe-unpipe-streams.js +++ b/test/parallel/test-stream-pipe-unpipe-streams.js @@ -4,9 +4,9 @@ const assert = require('assert'); const { Readable, Writable } = require('stream'); -const source = Readable({ read: () => {} }); -const dest1 = Writable({ write: () => {} }); -const dest2 = Writable({ write: () => {} }); +const source = Readable({ read: () => { } }); +const dest1 = Writable({ write: () => { } }); +const dest2 = Writable({ write: () => { } }); source.pipe(dest1); source.pipe(dest2); @@ -34,9 +34,9 @@ assert.strictEqual(source._readableState.pipes.length, 0); { // Test `cleanup()` if we unpipe all streams. - const source = Readable({ read: () => {} }); - const dest1 = Writable({ write: () => {} }); - const dest2 = Writable({ write: () => {} }); + const source = Readable({ read: () => { } }); + const dest1 = Writable({ write: () => { } }); + const dest2 = Writable({ write: () => { } }); let destCount = 0; const srcCheckEventNames = ['end', 'data']; @@ -45,13 +45,12 @@ assert.strictEqual(source._readableState.pipes.length, 0); const checkSrcCleanup = common.mustCall(() => { assert.strictEqual(source._readableState.pipes.length, 0); assert.strictEqual(source._readableState.flowing, false); - - srcCheckEventNames.forEach((eventName) => { + for (let eventName of srcCheckEventNames) { assert.strictEqual( source.listenerCount(eventName), 0, `source's '${eventName}' event listeners not removed` ); - }); + } }); function checkDestCleanup(dest) { @@ -65,13 +64,13 @@ assert.strictEqual(source._readableState.pipes.length, 0); 'listener which is `unpipeChecker`' ); dest.removeListener('unpipe', unpipeChecker); - destCheckEventNames.forEach((eventName) => { + for (const eventName of destCheckEventNames) { assert.strictEqual( dest.listenerCount(eventName), 0, `destination{${currentDestId}}'s '${eventName}' event ` + 'listeners not removed' ); - }); + } if (--destCount === 0) checkSrcCleanup(); @@ -86,8 +85,8 @@ assert.strictEqual(source._readableState.pipes.length, 0); } { - const src = Readable({ read: () => {} }); - const dst = Writable({ write: () => {} }); + const src = Readable({ read: () => { } }); + const dst = Writable({ write: () => { } }); src.pipe(dst); src.on('resume', common.mustCall(() => { src.on('pause', common.mustCall()); From aaaa0875b5aae7973b5998bfa1f2cade03e33bbb Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Fri, 15 Dec 2023 16:12:24 +0100 Subject: [PATCH 2/5] Update test/parallel/test-stream-pipe-unpipe-streams.js --- test/parallel/test-stream-pipe-unpipe-streams.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-stream-pipe-unpipe-streams.js b/test/parallel/test-stream-pipe-unpipe-streams.js index dcf59e835d830e..18b5b4a3892054 100644 --- a/test/parallel/test-stream-pipe-unpipe-streams.js +++ b/test/parallel/test-stream-pipe-unpipe-streams.js @@ -4,9 +4,9 @@ const assert = require('assert'); const { Readable, Writable } = require('stream'); -const source = Readable({ read: () => { } }); -const dest1 = Writable({ write: () => { } }); -const dest2 = Writable({ write: () => { } }); +const source = Readable({ read: () => {} }); +const dest1 = Writable({ write: () => {} }); +const dest2 = Writable({ write: () => {} }); source.pipe(dest1); source.pipe(dest2); From 30f8e57202ddede39d0f83345f4bb7db59a14b7f Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Fri, 15 Dec 2023 16:12:31 +0100 Subject: [PATCH 3/5] Update test/parallel/test-stream-pipe-unpipe-streams.js --- test/parallel/test-stream-pipe-unpipe-streams.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-stream-pipe-unpipe-streams.js b/test/parallel/test-stream-pipe-unpipe-streams.js index 18b5b4a3892054..2be05fbb68feb1 100644 --- a/test/parallel/test-stream-pipe-unpipe-streams.js +++ b/test/parallel/test-stream-pipe-unpipe-streams.js @@ -34,9 +34,9 @@ assert.strictEqual(source._readableState.pipes.length, 0); { // Test `cleanup()` if we unpipe all streams. - const source = Readable({ read: () => { } }); - const dest1 = Writable({ write: () => { } }); - const dest2 = Writable({ write: () => { } }); + const source = Readable({ read: () => {} }); + const dest1 = Writable({ write: () => {} }); + const dest2 = Writable({ write: () => {} }); let destCount = 0; const srcCheckEventNames = ['end', 'data']; From bf7c3f7433ad0a448bd3a751ac2dcf27bbec29b7 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Fri, 15 Dec 2023 16:12:36 +0100 Subject: [PATCH 4/5] Update test/parallel/test-stream-pipe-unpipe-streams.js --- test/parallel/test-stream-pipe-unpipe-streams.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-stream-pipe-unpipe-streams.js b/test/parallel/test-stream-pipe-unpipe-streams.js index 2be05fbb68feb1..51f7bfd9603daa 100644 --- a/test/parallel/test-stream-pipe-unpipe-streams.js +++ b/test/parallel/test-stream-pipe-unpipe-streams.js @@ -45,7 +45,7 @@ assert.strictEqual(source._readableState.pipes.length, 0); const checkSrcCleanup = common.mustCall(() => { assert.strictEqual(source._readableState.pipes.length, 0); assert.strictEqual(source._readableState.flowing, false); - for (let eventName of srcCheckEventNames) { + for (const eventName of srcCheckEventNames) { assert.strictEqual( source.listenerCount(eventName), 0, `source's '${eventName}' event listeners not removed` From 491e86c41ab82c9bb1803476a5dc975be5801a4e Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Fri, 15 Dec 2023 16:12:41 +0100 Subject: [PATCH 5/5] Update test/parallel/test-stream-pipe-unpipe-streams.js --- test/parallel/test-stream-pipe-unpipe-streams.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-stream-pipe-unpipe-streams.js b/test/parallel/test-stream-pipe-unpipe-streams.js index 51f7bfd9603daa..74c435399335d2 100644 --- a/test/parallel/test-stream-pipe-unpipe-streams.js +++ b/test/parallel/test-stream-pipe-unpipe-streams.js @@ -85,8 +85,8 @@ assert.strictEqual(source._readableState.pipes.length, 0); } { - const src = Readable({ read: () => { } }); - const dst = Writable({ write: () => { } }); + const src = Readable({ read: () => {} }); + const dst = Writable({ write: () => {} }); src.pipe(dst); src.on('resume', common.mustCall(() => { src.on('pause', common.mustCall());